[modules] Fix missing includes/typo in LLDB's includes. [NFC]

[teemperor]

Summary

This patch adds missing includes to the LLDB headers inside include/ as a first step of building LLDB's source with C++ modules. It also fixes this single stds:: typo.

Some quick map why some non-obvious includes were necessary:

• lldb/lldb-defines.h for LLDB_INVALID_ADDRESS
• lldb/lldb-types.h for addr_t
• lldb/lldb-defines.h for DISALLOW_COPY_AND_ASSIG
• lldb/DataFormatters/TypeSynthetic.h for SyntheticChildrenFrontEnd

[teemperor]

• Ditched the commented includes.

[aprantl]

Thanks! This looks generally good/useful as a cleanup, too.

include/lldb/Core/ThreadSafeDenseSet.h

49 ↗

(On Diff #130784)

Out of curiosity: Why/how did this work before??

[zturner]

include/lldb/Core/ThreadSafeDenseSet.h

49 ↗

(On Diff #130784)

My guess is nobody is actually using this class so the template was never instantiated.

lldb/trunk/include/lldb/Core/LoadedModuleInfoList.h

 //===-- LoadedModuleInfoList.h ----------------------------------*- C++ -*-===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef liblldb_LoadedModuleInfoList_h_
 #define liblldb_LoadedModuleInfoList_h_
 
 // C Includes
 
 // C++ Includes
+#include <cassert>
 #include <vector>
 
 // Other libraries and framework includes
+#include "lldb/lldb-defines.h"
 #include "lldb/lldb-private-forward.h"
+#include "lldb/lldb-types.h"
 
 namespace lldb_private {
 class LoadedModuleInfoList {
 public:
   class LoadedModuleInfo {
   public:
     enum e_data_point {
       e_has_name = 0,

lldb/trunk/include/lldb/Core/ThreadSafeDenseSet.h

public:
   }
 
   bool Lookup(_ElementType e) {
     std::lock_guard<_MutexType> guard(m_mutex);
     return (m_set.count(e) > 0);
   }
 
   void Clear() {
-    stds::lock_guard<_MutexType> guard(m_mutex);
+    std::lock_guard<_MutexType> guard(m_mutex);
     m_set.clear();
   }
 
 protected:
   LLVMSetType m_set;
   _MutexType m_mutex;
 };
 
 } // namespace lldb_private
 
 #endif // liblldb_ThreadSafeDenseSet_h_

lldb/trunk/include/lldb/Core/ThreadSafeValue.h

 
 // C Includes
 
 // C++ Includes
 #include <mutex>
 
 // Other libraries and framework includes
 // Project includes
+#include "lldb/lldb-defines.h"
 
 namespace lldb_private {
 
 template <class T> class ThreadSafeValue {
 public:
   //------------------------------------------------------------------
   // Constructors and Destructors
   //------------------------------------------------------------------

lldb/trunk/include/lldb/DataFormatters/VectorIterator.h

 //===-- VectorIterator.h ----------------------------------------------*- C++
 //-*-===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef liblldb_VectorIterator_h_
 #define liblldb_VectorIterator_h_
 
 #include "lldb/lldb-forward.h"
 
+#include "lldb/DataFormatters/TypeSynthetic.h"
 #include "lldb/Target/ExecutionContext.h"
 #include "lldb/Utility/ConstString.h"
 
 namespace lldb_private {
 namespace formatters {
 class VectorIteratorSyntheticFrontEnd : public SyntheticChildrenFrontEnd {
 public:
   VectorIteratorSyntheticFrontEnd(lldb::ValueObjectSP valobj_sp,

lldb/trunk/include/lldb/Target/ProcessStructReader.h

 #define LLDB_TARGET_PROCESSSTRUCTREADER_H
 
 #include "lldb/lldb-defines.h"
 #include "lldb/lldb-types.h"
 
 #include "lldb/Symbol/CompilerType.h"
 #include "lldb/Target/Process.h"
 #include "lldb/Utility/ConstString.h"
+#include "lldb/Utility/DataBufferHeap.h"
 #include "lldb/Utility/DataExtractor.h"
 #include "lldb/Utility/Status.h"
 
 #include <initializer_list>
 #include <map>
 #include <string>
 
 namespace lldb_private {

lldb/trunk/include/lldb/Utility/AnsiTerminal.h

 #define ANSI_STR(s) #s
 #define ANSI_DEF_STR(s) ANSI_STR(s)
 
 #define ANSI_ESCAPE1(s) ANSI_ESC_START ANSI_DEF_STR(s) ANSI_ESC_END
 
 #define ANSI_1_CTRL(ctrl1) "\033["##ctrl1 ANSI_ESC_END
 #define ANSI_2_CTRL(ctrl1, ctrl2) "\033["##ctrl1 ";"##ctrl2 ANSI_ESC_END
 
+#include "llvm/ADT/ArrayRef.h"
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/ADT/StringRef.h"
 
 #include <string>
 
 namespace lldb_utility {
 
 namespace ansi {

lldb/trunk/include/lldb/Utility/SharedCluster.h

 #ifndef utility_SharedCluster_h_
 #define utility_SharedCluster_h_
 
 #include "lldb/Utility/LLDBAssert.h"
 #include "lldb/Utility/SharingPtr.h"
 
 #include "llvm/ADT/SmallPtrSet.h"
 
+#include <mutex>
+
 namespace lldb_private {
 
 namespace imp {
 template <typename T>
 class shared_ptr_refcount : public lldb_private::imp::shared_count {
 public:
   template <class Y>
   shared_ptr_refcount(Y *in) : shared_count(0), manager(in) {}