Also fix a problem with CXXTemporaryObjectExpr.
Some of the changes based on https://github.com/haoNoQ/clang/blob/summary-ipa-draft/lib/AST/ASTImporter.cpp
Paths
| Differential D42335
[ASTImporter] Supporting CXXOperatorCallExpr, SizeOfPackExpr, DependentTemplateSpecializationType, DependentSizedArray, CXXTypeidExpr importing. ClosedPublic Authored by xazax.hun on Jan 20 2018, 9:25 AM.
Details Summary Also fix a problem with CXXTemporaryObjectExpr. Some of the changes based on https://github.com/haoNoQ/clang/blob/summary-ipa-draft/lib/AST/ASTImporter.cpp
Diff Detail
Event TimelineComment Actions Hello Peter, Thank you for the patch! It is almost LGTM, just a few minor questions inline.
Comment Actions
Yeah that is right. One reason I prefer matcher based tests because they tend to be more lightweight, but I think you are right, it is not a bad idea to utilize other tools as well. Comment Actions
xazax.hun retitled this revision from [ASTImporter] Supporting CXXOperatorCallExpr, SizeOfPackExpr, DependentTemplateSpecializationType, DependentSizedArray importing. to [ASTImporter] Supporting CXXOperatorCallExpr, SizeOfPackExpr, DependentTemplateSpecializationType, DependentSizedArray, CXXTypeidExpr importing.. Comment Actions
This revision is now accepted and ready to land.Jan 25 2018, 9:00 AM Closed by commit rC323589: [ASTImporter] Add support to import some AST nodes: (authored by xazax). · Explain WhyJan 27 2018, 8:15 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 131684 lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
|
Redundant newline? (Same below).