This is an archive of the discontinued LLVM Phabricator instance.

[ValueLattice] Use getters instead of direct accesses (NFC).
ClosedPublic

Authored by fhahn on Jan 18 2018, 4:00 PM.

Download Raw Diff

Details

Reviewers

reames
davide
anna

Commits

rG5045eaf9b961: [ValueLattice] Use getters instead of direct accesses (NFC).
rL322933: [ValueLattice] Use getters instead of direct accesses (NFC).

Diff Detail

Event Timeline

fhahn created this revision.Jan 18 2018, 4:00 PM

fhahn added a child revision: D41903: [ValueLattice] Use union to shave off ptr size bytes from elements..

reames accepted this revision.Jan 18 2018, 4:57 PM

This revision is now accepted and ready to land.Jan 18 2018, 4:57 PM

LGTM

Closed by commit rL322933: [ValueLattice] Use getters instead of direct accesses (NFC). (authored by fhahn). · Explain WhyJan 19 2018, 2:36 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

include/

llvm/

Analysis/

ValueLattice.h

6 lines

Diff 130514

include/llvm/Analysis/ValueLattice.h

Show First 20 Lines • Show All 183 Lines • ▼ Show 20 Lines	bool mergeIn(const ValueLatticeElement &RHS, const DataLayout &DL) {
}		}

if (isUndefined()) {		if (isUndefined()) {
*this = RHS;		*this = RHS;
return !RHS.isUndefined();		return !RHS.isUndefined();
}		}

if (isConstant()) {		if (isConstant()) {
if (RHS.isConstant() && Val == RHS.Val)		if (RHS.isConstant() && getConstant() == RHS.getConstant())
return false;		return false;
markOverdefined();		markOverdefined();
return true;		return true;
}		}

if (isNotConstant()) {		if (isNotConstant()) {
if (RHS.isNotConstant() && Val == RHS.Val)		if (RHS.isNotConstant() && getNotConstant() == RHS.getNotConstant())
return false;		return false;
markOverdefined();		markOverdefined();
return true;		return true;
}		}

assert(isConstantRange() && "New ValueLattice type?");		assert(isConstantRange() && "New ValueLattice type?");
if (!RHS.isConstantRange()) {		if (!RHS.isConstantRange()) {
// We can get here if we've encountered a constantexpr of integer type		// We can get here if we've encountered a constantexpr of integer type
// and merge it with a constantrange.		// and merge it with a constantrange.
markOverdefined();		markOverdefined();
return true;		return true;
}		}
ConstantRange NewR = Range.unionWith(RHS.getConstantRange());		ConstantRange NewR = getConstantRange().unionWith(RHS.getConstantRange());
if (NewR.isFullSet())		if (NewR.isFullSet())
markOverdefined();		markOverdefined();
else		else
markConstantRange(std::move(NewR));		markConstantRange(std::move(NewR));
return true;		return true;
}		}

ConstantInt *getConstantInt() const {		ConstantInt *getConstantInt() const {
Show All 30 Lines