This is an archive of the discontinued LLVM Phabricator instance.

Set Module Metadata "AvoidPLT" when -fno-plt is used.
ClosedPublic

Authored by tmsriram on Jan 17 2018, 4:50 PM.

Download Raw Diff

Details

Reviewers

rnk
• rafael

Commits

rG80af005a4853: Set Module Metadata "RtLibUseGOT" when fno-plt is used.
rC325961: Set Module Metadata "RtLibUseGOT" when fno-plt is used.
rL325961: Set Module Metadata "RtLibUseGOT" when fno-plt is used.

Summary

Set Module Metadata "AvoidPLT" when -fno-plt is used.

Please see:
https://reviews.llvm.org/D42216 for more details.

This allows processing of calls to intrinsics easily.

Diff Detail

Event Timeline

tmsriram created this revision.Jan 17 2018, 4:50 PM

METADATA tag changed to "RtLibUseGOT". Also see: https://reviews.llvm.org/D42224/

Updated patch.

Ping. This patch goes with https://reviews.llvm.org/D42216, Rafael can you approve this too if you think it is ok? Thanks.

Ping.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 23 2018, 1:30 PM

Closed by commit rL325961: Set Module Metadata "RtLibUseGOT" when fno-plt is used. (authored by tmsriram). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: llvm-commits. · View Herald TranscriptFeb 23 2018, 1:30 PM

Revision Contents

Path

Size

lib/

CodeGen/

CodeGenModule.cpp

4 lines

test/

CodeGen/

noplt.c

3 lines

Diff 135144

lib/CodeGen/CodeGenModule.cpp

Show First 20 Lines • Show All 549 Lines • ▼ Show 20 Lines	void CodeGenModule::Release() {

if (uint32_t PLevel = Context.getLangOpts().PICLevel) {		if (uint32_t PLevel = Context.getLangOpts().PICLevel) {
assert(PLevel < 3 && "Invalid PIC Level");		assert(PLevel < 3 && "Invalid PIC Level");
getModule().setPICLevel(static_cast<llvm::PICLevel::Level>(PLevel));		getModule().setPICLevel(static_cast<llvm::PICLevel::Level>(PLevel));
if (Context.getLangOpts().PIE)		if (Context.getLangOpts().PIE)
getModule().setPIELevel(static_cast<llvm::PIELevel::Level>(PLevel));		getModule().setPIELevel(static_cast<llvm::PIELevel::Level>(PLevel));
}		}

		if (CodeGenOpts.NoPLT) {
		getModule().setRtLibUseGOT();
		}

SimplifyPersonality();		SimplifyPersonality();

if (getCodeGenOpts().EmitDeclMetadata)		if (getCodeGenOpts().EmitDeclMetadata)
EmitDeclMetadata();		EmitDeclMetadata();

if (getCodeGenOpts().EmitGcovArcs \|\| getCodeGenOpts().EmitGcovNotes)		if (getCodeGenOpts().EmitGcovArcs \|\| getCodeGenOpts().EmitGcovNotes)
EmitCoverageFile();		EmitCoverageFile();

▲ Show 20 Lines • Show All 4,421 Lines • Show Last 20 Lines

test/CodeGen/noplt.c

	// RUN: %clang_cc1 -emit-llvm -fno-plt %s -o - \| FileCheck %s -check-prefix=CHECK-NOPLT			// RUN: %clang_cc1 -emit-llvm -fno-plt %s -o - \| FileCheck %s -check-prefix=CHECK-NOPLT -check-prefix=CHECK-NOPLT-METADATA

	// CHECK-NOPLT: Function Attrs: nonlazybind			// CHECK-NOPLT: Function Attrs: nonlazybind
	// CHECK-NOPLT-NEXT: declare {{.*}}i32 @foo			// CHECK-NOPLT-NEXT: declare {{.*}}i32 @foo
				// CHECK-NOPLT-METADATA: !"RtLibUseGOT"
	int foo();			int foo();

	int bar() {			int bar() {
	return foo();			return foo();
	}			}