This is an archive of the discontinued LLVM Phabricator instance.

Differential D42120

[clang-tidy] Fixing Fuchsia overloaded operator warning message
ClosedPublic

Authored by juliehockett on Jan 16 2018, 10:56 AM.

Details

Reviewers
alexfh
aaron.ballman
Commits
rG996a8c1a660f: [clang-tidy] Fixing Fuchsia overloaded operator warning message
rL322692: [clang-tidy] Fixing Fuchsia overloaded operator warning message
rCTE322692: [clang-tidy] Fixing Fuchsia overloaded operator warning message
Summary

Updating Fuchsia overloaded operator warning message for clarity.

Diff Detail

Event Timeline

juliehockett created this revision.Jan 16 2018, 10:56 AM
Herald added a subscriber: xazax.hun. · View Herald TranscriptJan 16 2018, 10:56 AM
aaron.ballman accepted this revision.Jan 16 2018, 11:01 AM
aaron.ballman added a subscriber: aaron.ballman.

LGTM!

test/clang-tidy/fuchsia-overloaded-operator.cpp
6

Can you remove the [fuchsia-overloaded-operator] from all of the comments in this file as well? That can be done in a follow-up commit and no review is needed for it.

This revision is now accepted and ready to land.Jan 16 2018, 11:01 AM
Closed by commit rCTE322692: [clang-tidy] Fixing Fuchsia overloaded operator warning message (authored by juliehockett). · Explain WhyJan 17 2018, 9:43 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang-tidy/
fuchsia/
2 lines
test/
clang-tidy/
10 lines

Diff 130205

clang-tidy/fuchsia/OverloadedOperatorCheck.cpp

Show All 29 Lines
} }
void OverloadedOperatorCheck::check(const MatchFinder::MatchResult &Result) { void OverloadedOperatorCheck::check(const MatchFinder::MatchResult &Result) {
const auto *D = Result.Nodes.getNodeAs<FunctionDecl>("decl"); const auto *D = Result.Nodes.getNodeAs<FunctionDecl>("decl");
assert(D && "No FunctionDecl captured!"); assert(D && "No FunctionDecl captured!");
SourceLocation Loc = D->getLocStart(); SourceLocation Loc = D->getLocStart();
if (Loc.isValid()) if (Loc.isValid())
diag(Loc, "cannot overload %0") << D; diag(Loc, "overloading %0 is disallowed") << D;
} }
} // namespace fuchsia } // namespace fuchsia
} // namespace tidy } // namespace tidy
} // namespace clang } // namespace clang

test/clang-tidy/fuchsia-overloaded-operator.cpp

// RUN: %check_clang_tidy %s fuchsia-overloaded-operator %t // RUN: %check_clang_tidy %s fuchsia-overloaded-operator %t
class A { class A {
public: public:
int operator+(int); int operator+(int);
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: cannot overload 'operator+' [fuchsia-overloaded-operator] // CHECK-MESSAGES: [[@LINE-1]]:3: warning: overloading 'operator+' is disallowed
aaron.ballmanUnsubmitted
Not Done
ReplyInline Actions

Can you remove the [fuchsia-overloaded-operator] from all of the comments in this file as well? That can be done in a follow-up commit and no review is needed for it.

aaron.ballman: Can you remove the `[fuchsia-overloaded-operator]` from all of the comments in this file as…
}; };
class B { class B {
public: public:
B &operator=(const B &Other); B &operator=(const B &Other);
// CHECK-MESSAGES-NOT: [[@LINE-1]]:3: warning: cannot overload 'operator=' [fuchsia-overloaded-operator] // CHECK-MESSAGES-NOT: [[@LINE-1]]:3: warning: overloading 'operator=' is disallowed
B &operator=(B &&Other); B &operator=(B &&Other);
// CHECK-MESSAGES-NOT: [[@LINE-1]]:3: warning: cannot overload 'operator=' [fuchsia-overloaded-operator] // CHECK-MESSAGES-NOT: [[@LINE-1]]:3: warning: overloading 'operator=' is disallowed
}; };
A operator-(const A &A1, const A &A2); A operator-(const A &A1, const A &A2);
// CHECK-MESSAGES: [[@LINE-1]]:1: warning: cannot overload 'operator-' [fuchsia-overloaded-operator] // CHECK-MESSAGES: [[@LINE-1]]:1: warning: overloading 'operator-' is disallowed
void operator delete(void*, void*) throw(); void operator delete(void*, void*) throw();
// CHECK-MESSAGES: [[@LINE-1]]:1: warning: cannot overload 'operator delete' [fuchsia-overloaded-operator] // CHECK-MESSAGES: [[@LINE-1]]:1: warning: overloading 'operator delete' is disallowed