This is an archive of the discontinued LLVM Phabricator instance.

[Solaris] Make RHEL devtoolsets handling Linux-specific
ClosedPublic

Authored by ro on Jan 13 2018, 6:51 AM.

Details

Summary

This patch is meant to address the last outstanding review comment on the already approved
(but not yet commited) https://reviews.llvm.org/D35755, namely making the handling of the RHEL
devtoolsets Linux-specific.

Don't know if it's best integrated into the former or applied subsequently.

Tested on i386-pc-solaris2.11 and x86_64-pc-linux-gnu.

Diff Detail

Repository
rL LLVM

Event Timeline

ro created this revision.Jan 13 2018, 6:51 AM
This revision is now accepted and ready to land.Jan 13 2018, 11:33 AM
ro added a comment.Jan 18 2018, 7:06 AM

Thanks for the quick review. Could you commit the base patch (which had been approved some time ago) and this one?

I'm trying!
I had no access to Solaris box, and I finally got one yesterday, though it is rather old one and slow.
I plan to resolve it all till the end of this week.

ro added a comment.Jan 18 2018, 8:03 AM

Excellent, thanks a lot.

This revision was automatically updated to reflect the committed changes.