Disable BinPackArguments and BinPackParameters in Google Objective-C style ⚙️

[stephanemoore]

Summary

Defaulting BinPackArguments and BinPackParameters to false is a better representation of Google Objective-C style.

[stephanemoore]

Sorted the Objective-C configuration for consistency.

[stephanemoore]

I am still working to verify that this change represents actual consensus. I will hold off on adding reviewers until then.

[benhamilton]

Check out D42650 for an alternative approach.

[stephanemoore]

After talking with Ben I think I will abandon this and we'll focus on separating Objective-C protocol list formatting out of BinPackParameters.

lib/Format/Format.cpp

if (Language == FormatStyle::LK_Java) {
     GoogleStyle.NamespaceIndentation = FormatStyle::NI_All;
     GoogleStyle.SpacesInContainerLiterals = false;
     GoogleStyle.JavaScriptQuotes = FormatStyle::JSQS_Single;
     GoogleStyle.JavaScriptWrapImports = false;
   } else if (Language == FormatStyle::LK_Proto) {
     GoogleStyle.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None;
     GoogleStyle.SpacesInContainerLiterals = false;
   } else if (Language == FormatStyle::LK_ObjC) {
+    GoogleStyle.BinPackArguments = false;
+    GoogleStyle.BinPackParameters = false;
     GoogleStyle.ColumnLimit = 100;
   }
 
   return GoogleStyle;
 }
 
 FormatStyle getChromiumStyle(FormatStyle::LanguageKind Language) {
   FormatStyle ChromiumStyle = getGoogleStyle(Language);