This is an archive of the discontinued LLVM Phabricator instance.

Differential D41892

libcxx: Stop providing a definition of __GLIBC_PREREQ.
ClosedPublic

Authored by pcc on Jan 9 2018, 5:12 PM.

Details

Reviewers
EricWF
mclow.lists
Commits
rG4566d827a1e9: libcxx: Stop providing a definition of __GLIBC_PREREQ.
rCXX322201: libcxx: Stop providing a definition of __GLIBC_PREREQ.
rL322201: libcxx: Stop providing a definition of __GLIBC_PREREQ.
Summary

An application may determine whether the C standard library is glibc
by testing whether __GLIBC_PREREQ is defined. This breaks if libc++
provides its own definition. Instead, define our own macro in our
namespace with the desired semantics.

Diff Detail

Event Timeline

pcc created this revision.Jan 9 2018, 5:12 PM
mclow.lists accepted this revision.Jan 10 2018, 6:53 AM

LGTM

This revision is now accepted and ready to land.Jan 10 2018, 6:53 AM
Closed by commit rL322201: libcxx: Stop providing a definition of __GLIBC_PREREQ. (authored by pcc). · Explain WhyJan 10 2018, 10:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
libcxx/
include/
12 lines

Diff 129193

libcxx/include/__config

Show First 20 Lines • Show All 178 Lines • ▼ Show 20 Lines
# else # else
# define _LIBCPP_ABI_ITANIUM # define _LIBCPP_ABI_ITANIUM
# endif # endif
#endif #endif
// Need to detect which libc we're using if we're on Linux. // Need to detect which libc we're using if we're on Linux.
#if defined(__linux__) #if defined(__linux__)
#include <features.h> #include <features.h>
#if !defined(__GLIBC_PREREQ) #if defined(__GLIBC_PREREQ)
#define __GLIBC_PREREQ(a, b) 0 #define _LIBCPP_GLIBC_PREREQ(a, b) __GLIBC_PREREQ(a, b)
#endif // !defined(__GLIBC_PREREQ) #else
#define _LIBCPP_GLIBC_PREREQ(a, b) 0
#endif // defined(__GLIBC_PREREQ)
#endif // defined(__linux__) #endif // defined(__linux__)
#ifdef __LITTLE_ENDIAN__ #ifdef __LITTLE_ENDIAN__
#if __LITTLE_ENDIAN__ #if __LITTLE_ENDIAN__
#define _LIBCPP_LITTLE_ENDIAN #define _LIBCPP_LITTLE_ENDIAN
#endif // __LITTLE_ENDIAN__ #endif // __LITTLE_ENDIAN__
#endif // __LITTLE_ENDIAN__ #endif // __LITTLE_ENDIAN__
▲ Show 20 Lines • Show All 213 Lines • ▼ Show 20 Lines
#if defined(__FreeBSD__) #if defined(__FreeBSD__)
#define _LIBCPP_HAS_QUICK_EXIT #define _LIBCPP_HAS_QUICK_EXIT
#define _LIBCPP_HAS_C11_FEATURES #define _LIBCPP_HAS_C11_FEATURES
#elif defined(__Fuchsia__) #elif defined(__Fuchsia__)
#define _LIBCPP_HAS_QUICK_EXIT #define _LIBCPP_HAS_QUICK_EXIT
#define _LIBCPP_HAS_C11_FEATURES #define _LIBCPP_HAS_C11_FEATURES
#elif defined(__linux__) #elif defined(__linux__)
#if !defined(_LIBCPP_HAS_MUSL_LIBC) #if !defined(_LIBCPP_HAS_MUSL_LIBC)
#if __GLIBC_PREREQ(2, 15) || defined(__BIONIC__) #if _LIBCPP_GLIBC_PREREQ(2, 15) || defined(__BIONIC__)
#define _LIBCPP_HAS_QUICK_EXIT #define _LIBCPP_HAS_QUICK_EXIT
#endif #endif
#if __GLIBC_PREREQ(2, 17) #if _LIBCPP_GLIBC_PREREQ(2, 17)
#define _LIBCPP_HAS_C11_FEATURES #define _LIBCPP_HAS_C11_FEATURES
#endif #endif
#else // defined(_LIBCPP_HAS_MUSL_LIBC) #else // defined(_LIBCPP_HAS_MUSL_LIBC)
#define _LIBCPP_HAS_QUICK_EXIT #define _LIBCPP_HAS_QUICK_EXIT
#define _LIBCPP_HAS_C11_FEATURES #define _LIBCPP_HAS_C11_FEATURES
#endif #endif
#endif // __linux__ #endif // __linux__
#endif #endif
▲ Show 20 Lines • Show All 859 Lines • Show Last 20 Lines