Added the FastVariableShuffle feature to cases that resembled processors
for which this fearure is on.
For AVX2 there are processors with and w/o this fearue enable.
For AVX512 only KNL does enable this feature so cases which only have
+avx512f were left without the FastVariableShuffle enabled.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
A few minor observations. Assuming D41436 is accepted, is the plan to remove the +fast-variable-shuffle arg from the avx512 cases? In which case might it make sense to commit the avx2 and avx512 changes separately?
test/CodeGen/X86/avx2-conversions.ll | ||
---|---|---|
5 ↗ | (On Diff #129036) | --check-prefixes=X64,X64-FAST |
test/CodeGen/X86/psubus.ll | ||
6 ↗ | (On Diff #129036) | --check-prefixes=AVX,AVX2,AVX2-SLOW |
8 ↗ | (On Diff #129036) | Possibly do the prefix cleanup as separate commit straight away? |
Comment Actions
IMO we should still have the flag enabled in the AVX512 tests to ensure that we are testing a configuration that resembles the processor it intends to cover.
Comment Actions
Rebase + apply fixes for Simon's comments. Will commit this change right away to avoid conflicts.