Page MenuHomePhabricator

X86 Tests: Update more isel tests with FastVariableShuffle feature
ClosedPublic

Authored by zvi on Jan 8 2018, 11:19 PM.

Details

Summary

Added the FastVariableShuffle feature to cases that resembled processors
for which this fearure is on.
For AVX2 there are processors with and w/o this fearue enable.
For AVX512 only KNL does enable this feature so cases which only have
+avx512f were left without the FastVariableShuffle enabled.

Diff Detail

Repository
rL LLVM

Event Timeline

zvi created this revision.Jan 8 2018, 11:19 PM

A few minor observations. Assuming D41436 is accepted, is the plan to remove the +fast-variable-shuffle arg from the avx512 cases? In which case might it make sense to commit the avx2 and avx512 changes separately?

test/CodeGen/X86/avx2-conversions.ll
5 ↗(On Diff #129036)

--check-prefixes=X64,X64-FAST

test/CodeGen/X86/psubus.ll
6 ↗(On Diff #129036)

--check-prefixes=AVX,AVX2,AVX2-SLOW

8 ↗(On Diff #129036)

Possibly do the prefix cleanup as separate commit straight away?

zvi added a comment.Jan 9 2018, 5:04 AM
Assuming D41436 is accepted, is the plan to remove the +fast-variable-shuffle arg from the avx512 cases? In which case might it make sense to commit the avx2 and avx512 changes separately?

IMO we should still have the flag enabled in the AVX512 tests to ensure that we are testing a configuration that resembles the processor it intends to cover.

OK. Apart from the minors I've already mentioned no further comment from me.

zvi added inline comments.Jan 9 2018, 8:01 AM
test/CodeGen/X86/avx2-conversions.ll
5 ↗(On Diff #129036)

thanks

test/CodeGen/X86/psubus.ll
6 ↗(On Diff #129036)

Good catch thanks

8 ↗(On Diff #129036)

Ok

zvi updated this revision to Diff 129091.Jan 9 2018, 8:20 AM

Rebase + apply fixes for Simon's comments. Will commit this change right away to avoid conflicts.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 9 2018, 8:27 AM
This revision was automatically updated to reflect the committed changes.