This is an archive of the discontinued LLVM Phabricator instance.

Differential D41847

[ELF] Explicit template instantiations for addFile
ClosedPublic

Authored by eraman on Jan 8 2018, 6:13 PM.

Details

Reviewers
• espindola
ruiu
smeenai
Commits
rGbfa48a14ab30: [ELF] Explicit template instantiations for addFile
rL322057: [ELF] Explicit template instantiations for addFile
rLLD322057: [ELF] Explicit template instantiations for addFile
Summary

All other templated methods have explicit instantiations but this one is
missing. Discovered while building with a clang with inliner
modifications.

Diff Detail

Event Timeline

eraman created this revision.Jan 8 2018, 6:13 PM
Herald added a subscriber: emaste. · View Herald TranscriptJan 8 2018, 6:13 PM
smeenai accepted this revision.Jan 8 2018, 6:27 PM
smeenai added a reviewer: ruiu.
smeenai added a subscriber: smeenai.

LGTM, given that it just seems like an oversight.

This revision is now accepted and ready to land.Jan 8 2018, 6:27 PM
Closed by commit rLLD322057: [ELF] Explicit template instantiations for addFile (authored by eraman). · Explain WhyJan 8 2018, 9:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
ELF/
5 lines

Diff 129019

ELF/SymbolTable.cpp

Show First 20 Lines • Show All 757 Lines • ▼ Show 20 Linesvoid SymbolTable::scanVersionScript() {
// Symbol themselves might know their versions because symbols // Symbol themselves might know their versions because symbols
// can contain versions in the form of <name>@<version>. // can contain versions in the form of <name>@<version>.
// Let them parse and update their names to exclude version suffix. // Let them parse and update their names to exclude version suffix.
for (Symbol *Sym : SymVector) for (Symbol *Sym : SymVector)
Sym->parseSymbolVersion(); Sym->parseSymbolVersion();
} }
template void SymbolTable::addFile<ELF32LE>(InputFile *);
template void SymbolTable::addFile<ELF32BE>(InputFile *);
template void SymbolTable::addFile<ELF64LE>(InputFile *);
template void SymbolTable::addFile<ELF64BE>(InputFile *);
template void SymbolTable::addSymbolWrap<ELF32LE>(StringRef); template void SymbolTable::addSymbolWrap<ELF32LE>(StringRef);
template void SymbolTable::addSymbolWrap<ELF32BE>(StringRef); template void SymbolTable::addSymbolWrap<ELF32BE>(StringRef);
template void SymbolTable::addSymbolWrap<ELF64LE>(StringRef); template void SymbolTable::addSymbolWrap<ELF64LE>(StringRef);
template void SymbolTable::addSymbolWrap<ELF64BE>(StringRef); template void SymbolTable::addSymbolWrap<ELF64BE>(StringRef);
template Symbol *SymbolTable::addUndefined<ELF32LE>(StringRef); template Symbol *SymbolTable::addUndefined<ELF32LE>(StringRef);
template Symbol *SymbolTable::addUndefined<ELF32BE>(StringRef); template Symbol *SymbolTable::addUndefined<ELF32BE>(StringRef);
template Symbol *SymbolTable::addUndefined<ELF64LE>(StringRef); template Symbol *SymbolTable::addUndefined<ELF64LE>(StringRef);
▲ Show 20 Lines • Show All 56 Lines • Show Last 20 Lines