This is an archive of the discontinued LLVM Phabricator instance.

Differential D41528

[Sema] Don't emit the -Wstrict-prototypes warning for variadic functions.
ClosedPublic

Authored by vsapsai on Dec 21 2017, 4:04 PM.

Details

Reviewers
arphaman
ahatanak
Commits
rG42b72e299432: [Sema] Don't emit the -Wstrict-prototypes warning for variadic functions.
rC321660: [Sema] Don't emit the -Wstrict-prototypes warning for variadic functions.
rL321660: [Sema] Don't emit the -Wstrict-prototypes warning for variadic functions.
Summary

rdar://problem/33251668

Diff Detail

Repository
rL LLVM

Event Timeline

vsapsai created this revision.Dec 21 2017, 4:04 PM
arphaman accepted this revision.Dec 21 2017, 4:06 PM

LGTM, thank you

This revision is now accepted and ready to land.Dec 21 2017, 4:06 PM
Closed by commit rL321660: [Sema] Don't emit the -Wstrict-prototypes warning for variadic functions. (authored by vsapsai). · Explain WhyJan 2 2018, 10:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cfe/
trunk/
lib/
Sema/
2 lines
test/
Sema/
6 lines

Diff 128430

cfe/trunk/lib/Sema/SemaType.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 4,761 Lines • ▼ Show 20 Lines if (!LangOpts.CPlusPlus && D.getFunctionDefinitionKind() == FDK_Declaration) {
bool IsBlock = false; bool IsBlock = false;
for (const DeclaratorChunk &DeclType : D.type_objects()) { for (const DeclaratorChunk &DeclType : D.type_objects()) {
switch (DeclType.Kind) { switch (DeclType.Kind) {
case DeclaratorChunk::BlockPointer: case DeclaratorChunk::BlockPointer:
IsBlock = true; IsBlock = true;
break; break;
case DeclaratorChunk::Function: { case DeclaratorChunk::Function: {
const DeclaratorChunk::FunctionTypeInfo &FTI = DeclType.Fun; const DeclaratorChunk::FunctionTypeInfo &FTI = DeclType.Fun;
if (FTI.NumParams == 0) if (FTI.NumParams == 0 && !FTI.isVariadic)
S.Diag(DeclType.Loc, diag::warn_strict_prototypes) S.Diag(DeclType.Loc, diag::warn_strict_prototypes)
<< IsBlock << IsBlock
<< FixItHint::CreateInsertion(FTI.getRParenLoc(), "void"); << FixItHint::CreateInsertion(FTI.getRParenLoc(), "void");
IsBlock = false; IsBlock = false;
break; break;
} }
default: default:
break; break;
▲ Show 20 Lines • Show All 3,211 Lines • Show Last 20 Lines

cfe/trunk/test/Sema/warn-strict-prototypes.c

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Lines
// K&R function definition with previous prototype declared is not diagnosed. // K&R function definition with previous prototype declared is not diagnosed.
void foo11(int p, int p2); void foo11(int p, int p2);
void foo11(p, p2) int p; int p2; {} void foo11(p, p2) int p; int p2; {}
// PR31020 // PR31020
void __attribute__((cdecl)) foo12(d) // expected-warning {{this old-style function definition is not preceded by a prototype}} void __attribute__((cdecl)) foo12(d) // expected-warning {{this old-style function definition is not preceded by a prototype}}
short d; short d;
{} {}
// No warnings for variadic functions. Overloadable attribute is required
// to avoid err_ellipsis_first_param error.
// rdar://problem/33251668
void foo13(...) __attribute__((overloadable));
void foo13(...) __attribute__((overloadable)) {}