Remove unused positional argument for printf

[protze.joachim]

Summary

gcc on Ubuntu compiles by default with -D_FORTIFY_SOURCE=2. This results in a fatal runtime error, when kmp_msg tries to print a hint:

*** invalid %N$ use detected ***

The format string for hints only prints the second argument (string) and drops the first argument (hint id). Depending on how you read the POSIX text for printf, this could be valid. But for practical reason, i.e., unpacking the va_list passed to printf based on the formating information, it makes sense to fix the implementation and not pass the id for hint.

Failing testcases are:

misc_bugs/teams-reduction.c
ompt/parallel/not_enough_threads.c

[omalyshe]

LGTM.
Verified on some other tests in Intel environment.

openmp/trunk/runtime/src/i18n/en_US.txt

 # --------------------------------------------------------------------------------------------------
 -*- FORMATS -*-
 # --------------------------------------------------------------------------------------------------
 
 Info                         "OMP: Info #%1$d: %2$s\n"
 Warning                      "OMP: Warning #%1$d: %2$s\n"
 Fatal                        "OMP: Error #%1$d: %2$s\n"
 SysErr                       "OMP: System error #%1$d: %2$s\n"
-Hint                         "OMP: Hint: %2$s\n"
+Hint                         "OMP: Hint %1$s\n"
 
 Pragma                       "%1$s pragma (at %2$s:%3$s():%4$s)"
     # %1 is pragma name (like "parallel" or "master",
     # %2 is file name,
     # %3 is function (routine) name,
     # %4 is the line number (as string, so "s" type specifier should be used).
 
 

openmp/trunk/runtime/src/kmp_i18n.cpp

void __kmp_msg(kmp_msg_severity_t severity, kmp_msg_t message, va_list args) {
   for (;;) {
     message = va_arg(args, kmp_msg_t);
     if (message.type == kmp_mt_dummy && message.str == NULL) {
       break;
     }
     switch (message.type) {
     case kmp_mt_hint: {
       format = kmp_i18n_fmt_Hint;
+      // we cannot skip %1$ and only use %2$ to print the message without the number
+      fmsg = __kmp_msg_format(format, message.str);
     } break;
     case kmp_mt_syserr: {
       format = kmp_i18n_fmt_SysErr;
+      fmsg = __kmp_msg_format(format, message.num, message.str);
     } break;
     default: { KMP_DEBUG_ASSERT(0); }
     }
-    fmsg = __kmp_msg_format(format, message.num, message.str);
     __kmp_str_free(&message.str);
     __kmp_str_buf_cat(&buffer, fmsg.str, fmsg.len);
     __kmp_str_free(&fmsg.str);
   }
 
   // Print formatted messages.
   // This lock prevents multiple fatal errors on the same problem.
   // __kmp_acquire_bootstrap_lock( & lock );    // GEH - This lock causing tests