This is an archive of the discontinued LLVM Phabricator instance.

[LLD] [MinGW] Ignore the --no-seh flag
ClosedPublic

Authored by mstorsjo on Dec 15 2017, 12:07 AM.

Details

Summary

The COFF linker automatically sets the IMAGE_DLL_CHARACTERISTICS_NO_SEH when suitable, similarly to link.exe.

(This description only is correct as long as D41252 is merged first, but I guess this change in itself could be merged independently.)

Diff Detail

Event Timeline

mstorsjo created this revision.Dec 15 2017, 12:07 AM
rnk added a comment.Dec 15 2017, 11:49 AM

lgtm

I think LLD's current behavior will make things "just work" in as many cases as possible.

We could consider adding a warning when there were .sxdata sections present in the input, but no _load_config_used symbol was found. This indicates that there *were* structured exception handlers, but there was no load config to point to the safe SEH table.

rnk accepted this revision.Dec 15 2017, 12:46 PM
This revision is now accepted and ready to land.Dec 15 2017, 12:46 PM
This revision was automatically updated to reflect the committed changes.