This is an archive of the discontinued LLVM Phabricator instance.

Use warn() instead of error() to report a bad symbol in a DSO.
ClosedPublic

Authored by ruiu on Dec 14 2017, 1:34 PM.

Event Timeline

ruiu created this revision.Dec 14 2017, 1:34 PM
ruiu updated this revision to Diff 127036.Dec 14 2017, 3:50 PM
  • Instead of adding a bad symbol to the symbol table, skip it.
pcc accepted this revision.Dec 14 2017, 3:53 PM

LGTM

lld/test/ELF/invalid-local-symbol-in-dso.s
4

Can we also test that we fail to link against the symbol?

This revision is now accepted and ready to land.Dec 14 2017, 3:53 PM
This revision was automatically updated to reflect the committed changes.
pcc added inline comments.Dec 14 2017, 4:14 PM
lld/trunk/test/ELF/invalid-local-symbol-in-dso.s
4 ↗(On Diff #127039)

Do you need to create an object file? Can you just pass the .so file?