This is an archive of the discontinued LLVM Phabricator instance.

[TextDiagnosticBuffer] Fix diagnostic note emission order.
ClosedPublic

Authored by jdenny on Dec 7 2017, 6:39 PM.

Details

Summary

The frontend currently groups diagnostics from the command line
according to diagnostic level, but that places all notes last. Fix
that by emitting such diagnostics in the order they were generated.

Diff Detail

Repository
rC Clang

Event Timeline

jdenny created this revision.Dec 7 2017, 6:39 PM
rsmith accepted this revision.Dec 8 2017, 7:28 PM

Huh, I'm amazed we've had this bug for so long. Thanks!

This revision is now accepted and ready to land.Dec 8 2017, 7:28 PM
jdenny added a comment.Dec 8 2017, 7:38 PM

Hi Richard. Thanks for accepting. I don't have commit privileges. Would you please commit for me?

This revision was automatically updated to reflect the committed changes.