[libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.

[STL_MSFT]

Summary

[libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.

I recently wrote a tool to audit MSVC's codebase for inconsistent line endings and unnecessary non-ASCII characters, and I ran it over libcxx's codebase too. I don't need any of these changes to be committed, so feel free to reject them - I just thought you might be interested.

There's a significant non-ASCII string in test/std/re/re.alg/re.alg.search/grep.pass.cpp which I haven't attempted to convert into escapes.

TODO.TXT
Avoid non-ASCII characters.

benchmarks/util_smartptr.bench.cpp
Change CRLF to LF.

test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_fr_FR.pass.cpp
Consistently comment "\u20ac" as EURO SIGN, its Unicode name, instead of the actual Unicode character.

test/std/utilities/allocator.adaptor/allocator.adaptor.members/construct_type.pass.cpp
Avoid non-ASCII dash.

[mclow.lists]

Except for the stuff in TODO.txt these look good to me.
We need to do some work on that file - it's pretty out of date.

[STL_MSFT]

Would you like me to drop the changes to TODO.TXT?

[lichray]

LGTM as-is with the changes to the TODO file...

[STL_MSFT]

Thanks, I've checked this in without the changes to TODO.TXT. Please let me know if you still want them, otherwise I consider this to be complete.

[mclow.lists]

Thanks, I've checked this in without the changes to TODO.TXT

Thanks - that works for me.

TODO.TXT

 * P0492r2 - Implement National body comments for Filesystem
     * INCOMPLETE - US 25: has_filename() is equivalent to just !empty()
     * INCOMPLETE - US 31: Everything is defined in terms of one implicit host system
     * INCOMPLETE - US 32: Meaning of 27.10.2.1 unclear
     * INCOMPLETE - US 33: Definition of canonical path problematic
     * INCOMPLETE - US 34: Are there attributes of a file that are not an aspect of the file system?
     * INCOMPLETE - US 35: What synchronization is required to avoid a file system race?
     * INCOMPLETE - US 36: Symbolic links themselves are attached to a directory via (hard) links
-    * INCOMPLETE - US 37: The term “redundant current directory (dot) elements” is not defined
-    * INCOMPLETE - US 38: Duplicates §17.3.16
+    * INCOMPLETE - US 37: The term "redundant current directory (dot) elements" is not defined
+    * INCOMPLETE - US 38: Duplicates 17.3.16
     * INCOMPLETE - US 39: Remove note: Dot and dot-dot are not directories
     * INCOMPLETE - US 40: Not all directories have a parent.
-    * INCOMPLETE - US 41: The term “parent directory” for a (non-directory) file is unusual
+    * INCOMPLETE - US 41: The term "parent directory" for a (non-directory) file is unusual
     * INCOMPLETE - US 42: Pathname resolution does not always resolve a symlink
     * INCOMPLETE - US 43: Concerns about encoded character types
     * INCOMPLETE - US 44: Definition of path in terms of a string requires leaky abstraction
     * INCOMPLETE - US 45: Generic format portability compromised by unspecified root-name
     * INCOMPLETE - US 46: filename can be empty so productions for relative-path are redundant
-    * INCOMPLETE - US 47: “.” and “..” already match the name production
+    * INCOMPLETE - US 47: "." and ".." already match the name production
     * INCOMPLETE - US 48: Multiple separators are often meaningful in a root-name
-    * INCOMPLETE - US 49: What does “method of conversion method” mean?
-    * INCOMPLETE - US 50: 27.10.8.1 ¶ 1.4 largely redundant with ¶ 1.3
+    * INCOMPLETE - US 49: What does "method of conversion method" mean?
+    * INCOMPLETE - US 50: 27.10.8.1 p1.4 largely redundant with p1.3
     * INCOMPLETE - US 51: Failing to add / when appending empty string prevents useful apps
     * INCOMPLETE - US 52: remove_filename() postcondition is not by itself a definition
     * INCOMPLETE - US 53: remove_filename()'s name does not correspond to its behavior
     * INCOMPLETE - US 54: remove_filename() is broken
     * INCOMPLETE - US 55: replace_extension()'s use of path as parameter is inappropriate
     * INCOMPLETE - US 56: Remove replace_extension()'s conditional addition of period
     * INCOMPLETE - US 57: On Windows, absolute paths will sort in among relative paths
     * INCOMPLETE - US 58: parent_path() behavior for root paths is useless
     * INCOMPLETE - US 59: filename() returning path for single path components is bizarre
     * INCOMPLETE - US 60: path("/foo/").filename()==path(".") is surprising
     * INCOMPLETE - US 61: Leading dots in filename() should not begin an extension
     * INCOMPLETE - US 62: It is important that stem()+extension()==filename()
     * INCOMPLETE - US 63: lexically_normal() inconsistently treats trailing "/" but not "/.." as directory
     * INCOMPLETE - US 73, CA 2: root-name is effectively implementation defined
-    * INCOMPLETE - US 74, CA 3: The term “pathname” is ambiguous in some contexts
+    * INCOMPLETE - US 74, CA 3: The term "pathname" is ambiguous in some contexts
     * INCOMPLETE - US 75, CA 4: Extra flag in path constructors is needed
     * INCOMPLETE - US 76, CA 5: root-name definition is over-specified.
     * INCOMPLETE - US 77, CA 6: operator/ and other appends not useful if arg has root-name
     * INCOMPLETE - US 78, CA 7: Member absolute() in 27.10.4.1 is overspecified for non-POSIX-like O/S
     * INCOMPLETE - US 79, CA 8: Some operation functions are overspecified for implementation-defined file types
     * INCOMPLETE - US 185: Fold error_code and non-error_code signatures into one signature
     * INCOMPLETE - FI 14: directory_entry comparisons are members
     * INCOMPLETE - Late 36: permissions() error_code overload should be noexcept

benchmarks/util_smartptr.bench.cpp

-//===----------------------------------------------------------------------===//
-//
-//                     The LLVM Compiler Infrastructure
-//
-// This file is dual licensed under the MIT and the University of Illinois Open
-// Source Licenses. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-#include <memory>
-
-#include "benchmark/benchmark_api.h"
-
-static void BM_SharedPtrCreateDestroy(benchmark::State& st) {
-  while (st.KeepRunning()) {
-    auto sp = std::make_shared<int>(42);
-    benchmark::DoNotOptimize(sp.get());
-  }
-}
-BENCHMARK(BM_SharedPtrCreateDestroy);
-
-static void BM_SharedPtrIncDecRef(benchmark::State& st) {
-  auto sp = std::make_shared<int>(42);
-  benchmark::DoNotOptimize(sp.get());
-  while (st.KeepRunning()) {
-    std::shared_ptr<int> sp2(sp);
-    benchmark::ClobberMemory();
-  }
-}
-BENCHMARK(BM_SharedPtrIncDecRef);
-
-static void BM_WeakPtrIncDecRef(benchmark::State& st) {
-  auto sp = std::make_shared<int>(42);
-  benchmark::DoNotOptimize(sp.get());
-  while (st.KeepRunning()) {
-    std::weak_ptr<int> wp(sp);
-    benchmark::ClobberMemory();
-  }
-}
-BENCHMARK(BM_WeakPtrIncDecRef);
-
-BENCHMARK_MAIN()
+//===----------------------------------------------------------------------===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is dual licensed under the MIT and the University of Illinois Open
+// Source Licenses. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+
+#include <memory>
+
+#include "benchmark/benchmark_api.h"
+
+static void BM_SharedPtrCreateDestroy(benchmark::State& st) {
+  while (st.KeepRunning()) {
+    auto sp = std::make_shared<int>(42);
+    benchmark::DoNotOptimize(sp.get());
+  }
+}
+BENCHMARK(BM_SharedPtrCreateDestroy);
+
+static void BM_SharedPtrIncDecRef(benchmark::State& st) {
+  auto sp = std::make_shared<int>(42);
+  benchmark::DoNotOptimize(sp.get());
+  while (st.KeepRunning()) {
+    std::shared_ptr<int> sp2(sp);
+    benchmark::ClobberMemory();
+  }
+}
+BENCHMARK(BM_SharedPtrIncDecRef);
+
+static void BM_WeakPtrIncDecRef(benchmark::State& st) {
+  auto sp = std::make_shared<int>(42);
+  benchmark::DoNotOptimize(sp.get());
+  while (st.KeepRunning()) {
+    std::weak_ptr<int> wp(sp);
+    benchmark::ClobberMemory();
+  }
+}
+BENCHMARK(BM_WeakPtrIncDecRef);
+
+BENCHMARK_MAIN()

test/std/localization/locale.categories/category.monetary/locale.money.get/locale.money.get.members/get_long_double_fr_FR.pass.cpp

ios.imbue(std::locale(ios.getloc(),
             std::ios_base::iostate err = std::ios_base::goodbit;
             I iter = f.get(I(v.data()), I(v.data() + v.size()),
                                                 false, ios, err, ex);
             assert(iter.base() == v.data() + v.size());
             assert(err == std::ios_base::eofbit);
             assert(ex == -123456789);
         }
         {   // zero, showbase
-            std::string v = "0,00 \u20ac";  // €
+            std::string v = "0,00 \u20ac";  // EURO SIGN
             showbase(ios);
             typedef input_iterator<const char*> I;
             long double ex;
             std::ios_base::iostate err = std::ios_base::goodbit;
             I iter = f.get(I(v.data()), I(v.data() + v.size()),
                                                 false, ios, err, ex);
             assert(iter.base() == v.data() + v.size());
             assert(err == std::ios_base::eofbit);
             assert(ex == 0);
         }
         {   // zero, showbase
-            std::string v = "0,00 \u20ac";  // €
+            std::string v = "0,00 \u20ac";  // EURO SIGN
             showbase(ios);
             typedef input_iterator<const char*> I;
             long double ex;
             std::ios_base::iostate err = std::ios_base::goodbit;
             I iter = f.get(I(v.data()), I(v.data() + v.size()),
                                                 false, ios, err, ex);
             assert(iter.base() == v.data() + v.size());
             assert(err == std::ios_base::eofbit);
             assert(ex == 0);
         }
         {   // negative one, showbase
-            std::string v = "-0,01 \u20ac";
+            std::string v = "-0,01 \u20ac";  // EURO SIGN
             typedef input_iterator<const char*> I;
             long double ex;
             std::ios_base::iostate err = std::ios_base::goodbit;
             I iter = f.get(I(v.data()), I(v.data() + v.size()),
                                                 false, ios, err, ex);
             assert(iter.base() == v.data() + v.size());
             assert(err == std::ios_base::eofbit);
             assert(ex == -1);
         }
         {   // negative one, showbase
-            std::string v = "-0,01 \u20ac";
+            std::string v = "-0,01 \u20ac";  // EURO SIGN
             showbase(ios);
             typedef input_iterator<const char*> I;
             long double ex;
             std::ios_base::iostate err = std::ios_base::goodbit;
             I iter = f.get(I(v.data()), I(v.data() + v.size()),
                                                 false, ios, err, ex);
             assert(iter.base() == v.data() + v.size());
             assert(err == std::ios_base::eofbit);
             assert(ex == -1);
         }
         {   // positive, showbase
-            std::string v = "1 234 567,89 \u20ac";
+            std::string v = "1 234 567,89 \u20ac";  // EURO SIGN
             typedef input_iterator<const char*> I;
             long double ex;
             std::ios_base::iostate err = std::ios_base::goodbit;
             I iter = f.get(I(v.data()), I(v.data() + v.size()),
                                                 false, ios, err, ex);
             assert(iter.base() == v.data() + v.size());
             assert(err == std::ios_base::eofbit);
             assert(ex == 123456789);
         }
         {   // positive, showbase
-            std::string v = "1 234 567,89 \u20ac";
+            std::string v = "1 234 567,89 \u20ac";  // EURO SIGN
             showbase(ios);
             typedef input_iterator<const char*> I;
             long double ex;
             std::ios_base::iostate err = std::ios_base::goodbit;
             I iter = f.get(I(v.data()), I(v.data() + v.size()),
                                                 false, ios, err, ex);
             assert(iter.base() == v.data() + v.size());
             assert(err == std::ios_base::eofbit);
             assert(ex == 123456789);
             noshowbase(ios);
         }
         {   // negative, showbase
-            std::string v = "-1 234 567,89 \u20ac";
+            std::string v = "-1 234 567,89 \u20ac";  // EURO SIGN
             showbase(ios);
             typedef input_iterator<const char*> I;
             long double ex;
             std::ios_base::iostate err = std::ios_base::goodbit;
             I iter = f.get(I(v.data()), I(v.data() + v.size()),
                                                 false, ios, err, ex);
             assert(iter.base() == v.data() + v.size());
             assert(err == std::ios_base::eofbit);
ios.imbue(std::locale(ios.getloc(),
             std::ios_base::iostate err = std::ios_base::goodbit;
             I iter = f.get(I(v.data()), I(v.data() + v.size()),
                                                 false, ios, err, ex);
             assert(iter.base() == v.data() + v.size());
             assert(err == std::ios_base::eofbit);
             assert(ex == -123456789);
         }
         {   // zero, showbase
-            std::wstring v = L"0,00 \u20ac";
+            std::wstring v = L"0,00 \u20ac";  // EURO SIGN
             showbase(ios);
             typedef input_iterator<const wchar_t*> I;
             long double ex;
             std::ios_base::iostate err = std::ios_base::goodbit;
             I iter = f.get(I(v.data()), I(v.data() + v.size()),
                                                 false, ios, err, ex);
             assert(iter.base() == v.data() + v.size());
             assert(err == std::ios_base::eofbit);
             assert(ex == 0);
         }
         {   // zero, showbase
-            std::wstring v = L"0,00 \u20ac";
+            std::wstring v = L"0,00 \u20ac";  // EURO SIGN
             showbase(ios);
             typedef input_iterator<const wchar_t*> I;
             long double ex;
             std::ios_base::iostate err = std::ios_base::goodbit;
             I iter = f.get(I(v.data()), I(v.data() + v.size()),
                                                 false, ios, err, ex);
             assert(iter.base() == v.data() + v.size());
             assert(err == std::ios_base::eofbit);
             assert(ex == 0);
         }
         {   // negative one, showbase
-            std::wstring v = L"-0,01 \u20ac";
+            std::wstring v = L"-0,01 \u20ac";  // EURO SIGN
             typedef input_iterator<const wchar_t*> I;
             long double ex;
             std::ios_base::iostate err = std::ios_base::goodbit;
             I iter = f.get(I(v.data()), I(v.data() + v.size()),
                                                 false, ios, err, ex);
             assert(iter.base() == v.data() + v.size());
             assert(err == std::ios_base::eofbit);
             assert(ex == -1);
         }
         {   // negative one, showbase
-            std::wstring v = L"-0,01 \u20ac";
+            std::wstring v = L"-0,01 \u20ac";  // EURO SIGN
             showbase(ios);
             typedef input_iterator<const wchar_t*> I;
             long double ex;
             std::ios_base::iostate err = std::ios_base::goodbit;
             I iter = f.get(I(v.data()), I(v.data() + v.size()),
                                                 false, ios, err, ex);
             assert(iter.base() == v.data() + v.size());
             assert(err == std::ios_base::eofbit);
             assert(ex == -1);
         }
         {   // positive, showbase
-            std::wstring v = L"1 234 567,89 \u20ac";
+            std::wstring v = L"1 234 567,89 \u20ac";  // EURO SIGN
             typedef input_iterator<const wchar_t*> I;
             long double ex;
             std::ios_base::iostate err = std::ios_base::goodbit;
             I iter = f.get(I(v.data()), I(v.data() + v.size()),
                                                 false, ios, err, ex);
             assert(iter.base() == v.data() + v.size());
             assert(err == std::ios_base::eofbit);
             assert(ex == 123456789);
         }
         {   // positive, showbase
-            std::wstring v = L"1 234 567,89 \u20ac";
+            std::wstring v = L"1 234 567,89 \u20ac";  // EURO SIGN
             showbase(ios);
             typedef input_iterator<const wchar_t*> I;
             long double ex;
             std::ios_base::iostate err = std::ios_base::goodbit;
             I iter = f.get(I(v.data()), I(v.data() + v.size()),
                                                 false, ios, err, ex);
             assert(iter.base() == v.data() + v.size());
             assert(err == std::ios_base::eofbit);
             assert(ex == 123456789);
             noshowbase(ios);
         }
         {   // negative, showbase
-            std::wstring v = L"-1 234 567,89 \u20ac";
+            std::wstring v = L"-1 234 567,89 \u20ac";  // EURO SIGN
             showbase(ios);
             typedef input_iterator<const wchar_t*> I;
             long double ex;
             std::ios_base::iostate err = std::ios_base::goodbit;
             I iter = f.get(I(v.data()), I(v.data() + v.size()),
                                                 false, ios, err, ex);
             assert(iter.base() == v.data() + v.size());
             assert(err == std::ios_base::eofbit);

test/std/utilities/allocator.adaptor/allocator.adaptor.members/construct_type.pass.cpp

 #include <type_traits>
 #include <utility>
 #include <tuple>
 #include <cassert>
 #include <cstdlib>
 #include "uses_alloc_types.hpp"
 #include "controlled_allocators.hpp"
 
-// — If uses_allocator_v<T, inner_allocator_type> is false and
+// - If uses_allocator_v<T, inner_allocator_type> is false and
 //   is_constructible_v<T, Args...> is true, calls
 //   OUTERMOST_ALLOC_TRAITS(*this)::construct(
 //      OUTERMOST (*this), p, std::forward<Args>(args)...).
 void test_bullet_one() {
     using VoidAlloc2 = CountingAllocator<void, 2>;
 
     AllocController POuter;
     AllocController PInner;