This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt][xray][cmake] Fix a build issue caused by set/item mixup
ClosedPublic

Authored by sdardis on Dec 6 2017, 4:58 AM.

Details

Summary

r319165 introduced a change to CMakeLists.txt for xray where the set of supported
architectures for XRay was iterated over, tested if they could be targeted then
passed to add_compiler_rt_object_libraries. However all targets were passed,
rather than the architecture that was just tested. For cases such as MIPS, where
mips and mips64 are supported, cmake would then test if mips64 could be targetted
resulting in an attempt to produce multiple identical logical target names, falling
afowl of CMP0002.

Diff Detail

Repository
rL LLVM

Event Timeline

sdardis created this revision.Dec 6 2017, 4:58 AM
dberris accepted this revision.Dec 6 2017, 5:01 AM

Wow. Good catch -- thanks @sdardis!

This revision is now accepted and ready to land.Dec 6 2017, 5:01 AM
This revision was automatically updated to reflect the committed changes.