This is an archive of the discontinued LLVM Phabricator instance.

[msan] add strtouq msan interceptor
ClosedPublic

Authored by vitalybuka on Dec 5 2017, 1:56 PM.

Download Raw Diff

Details

Reviewers

Commits

rGf7b63c5f2b8e: [msan] add strtouq msan interceptor
rL319843: [msan] add strtouq msan interceptor
rCRT319843: [msan] add strtouq msan interceptor

Summary

Fixes https://github.com/google/sanitizers/issues/892

Diff Detail

Build Status

Buildable 12773
Build 12773: arc lint + arc unit

Event Timeline

vitalybuka created this revision.Dec 5 2017, 1:56 PM

Harbormaster completed remote builds in B12773: Diff 125606.Dec 5 2017, 1:56 PM

format

Harbormaster completed remote builds in B12774: Diff 125607.Dec 5 2017, 1:56 PM

eugenis accepted this revision.Dec 5 2017, 1:58 PM

eugenis added inline comments.

compiler-rt/lib/msan/msan_interceptors.cc
407	Perhaps return u64 instead of unsigned long long?

This revision is now accepted and ready to land.Dec 5 2017, 1:58 PM

u64

Harbormaster completed remote builds in B12775: Diff 125610.Dec 5 2017, 2:07 PM

Closed by commit rCRT319843: [msan] add strtouq msan interceptor (authored by vitalybuka). · Explain WhyDec 5 2017, 2:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

compiler-rt/

lib/

msan/

msan_interceptors.cc

2 lines

tests/

msan_test.cc

1 line

Diff 125606

compiler-rt/lib/msan/msan_interceptors.cc

Show First 20 Lines • Show All 398 Lines • ▼ Show 20 Lines

INTERCEPTORS_STRTO(double, strtod, char) // NOLINT		INTERCEPTORS_STRTO(double, strtod, char) // NOLINT
INTERCEPTORS_STRTO(float, strtof, char) // NOLINT		INTERCEPTORS_STRTO(float, strtof, char) // NOLINT
INTERCEPTORS_STRTO(long double, strtold, char) // NOLINT		INTERCEPTORS_STRTO(long double, strtold, char) // NOLINT
INTERCEPTORS_STRTO_BASE(long, strtol, char) // NOLINT		INTERCEPTORS_STRTO_BASE(long, strtol, char) // NOLINT
INTERCEPTORS_STRTO_BASE(long long, strtoll, char) // NOLINT		INTERCEPTORS_STRTO_BASE(long long, strtoll, char) // NOLINT
INTERCEPTORS_STRTO_BASE(unsigned long, strtoul, char) // NOLINT		INTERCEPTORS_STRTO_BASE(unsigned long, strtoul, char) // NOLINT
INTERCEPTORS_STRTO_BASE(unsigned long long, strtoull, char) // NOLINT		INTERCEPTORS_STRTO_BASE(unsigned long long, strtoull, char) // NOLINT
		INTERCEPTORS_STRTO_BASE(unsigned long long, strtouq, char) // NOLINT
		eugenisUnsubmitted Not Done Reply Inline Actions Perhaps return u64 instead of unsigned long long? eugenis: Perhaps return u64 instead of unsigned long long?

INTERCEPTORS_STRTO(double, wcstod, wchar_t) // NOLINT		INTERCEPTORS_STRTO(double, wcstod, wchar_t) // NOLINT
INTERCEPTORS_STRTO(float, wcstof, wchar_t) // NOLINT		INTERCEPTORS_STRTO(float, wcstof, wchar_t) // NOLINT
INTERCEPTORS_STRTO(long double, wcstold, wchar_t) // NOLINT		INTERCEPTORS_STRTO(long double, wcstold, wchar_t) // NOLINT
INTERCEPTORS_STRTO_BASE(long, wcstol, wchar_t) // NOLINT		INTERCEPTORS_STRTO_BASE(long, wcstol, wchar_t) // NOLINT
INTERCEPTORS_STRTO_BASE(long long, wcstoll, wchar_t) // NOLINT		INTERCEPTORS_STRTO_BASE(long long, wcstoll, wchar_t) // NOLINT
INTERCEPTORS_STRTO_BASE(unsigned long, wcstoul, wchar_t) // NOLINT		INTERCEPTORS_STRTO_BASE(unsigned long, wcstoul, wchar_t) // NOLINT
INTERCEPTORS_STRTO_BASE(unsigned long long, wcstoull, wchar_t) // NOLINT		INTERCEPTORS_STRTO_BASE(unsigned long long, wcstoull, wchar_t) // NOLINT
▲ Show 20 Lines • Show All 1,113 Lines • ▼ Show 20 Lines	void InitializeInterceptors() {
INTERCEPT_FUNCTION(strncat); // NOLINT		INTERCEPT_FUNCTION(strncat); // NOLINT
INTERCEPT_STRTO(strtod);		INTERCEPT_STRTO(strtod);
INTERCEPT_STRTO(strtof);		INTERCEPT_STRTO(strtof);
INTERCEPT_STRTO(strtold);		INTERCEPT_STRTO(strtold);
INTERCEPT_STRTO(strtol);		INTERCEPT_STRTO(strtol);
INTERCEPT_STRTO(strtoul);		INTERCEPT_STRTO(strtoul);
INTERCEPT_STRTO(strtoll);		INTERCEPT_STRTO(strtoll);
INTERCEPT_STRTO(strtoull);		INTERCEPT_STRTO(strtoull);
		INTERCEPT_STRTO(strtouq);
INTERCEPT_STRTO(wcstod);		INTERCEPT_STRTO(wcstod);
INTERCEPT_STRTO(wcstof);		INTERCEPT_STRTO(wcstof);
INTERCEPT_STRTO(wcstold);		INTERCEPT_STRTO(wcstold);
INTERCEPT_STRTO(wcstol);		INTERCEPT_STRTO(wcstol);
INTERCEPT_STRTO(wcstoul);		INTERCEPT_STRTO(wcstoul);
INTERCEPT_STRTO(wcstoll);		INTERCEPT_STRTO(wcstoll);
INTERCEPT_STRTO(wcstoull);		INTERCEPT_STRTO(wcstoull);
#ifdef SANITIZER_NLDBL_VERSION		#ifdef SANITIZER_NLDBL_VERSION
▲ Show 20 Lines • Show All 66 Lines • Show Last 20 Lines

compiler-rt/lib/msan/tests/msan_test.cc

Show First 20 Lines • Show All 1,782 Lines • ▼ Show 20 Lines	TEST(MemorySanitizer, func_name) { \
EXPECT_NOT_POISONED((S8)e); \		EXPECT_NOT_POISONED((S8)e); \
freelocale(loc); \		freelocale(loc); \
}		}

TEST_STRTO_INT(strtol, char, )		TEST_STRTO_INT(strtol, char, )
TEST_STRTO_INT(strtoll, char, )		TEST_STRTO_INT(strtoll, char, )
TEST_STRTO_INT(strtoul, char, )		TEST_STRTO_INT(strtoul, char, )
TEST_STRTO_INT(strtoull, char, )		TEST_STRTO_INT(strtoull, char, )
		TEST_STRTO_INT(strtouq, char, )

TEST_STRTO_FLOAT(strtof, char, )		TEST_STRTO_FLOAT(strtof, char, )
TEST_STRTO_FLOAT(strtod, char, )		TEST_STRTO_FLOAT(strtod, char, )
TEST_STRTO_FLOAT(strtold, char, )		TEST_STRTO_FLOAT(strtold, char, )

TEST_STRTO_FLOAT_LOC(strtof_l, char, )		TEST_STRTO_FLOAT_LOC(strtof_l, char, )
TEST_STRTO_FLOAT_LOC(strtod_l, char, )		TEST_STRTO_FLOAT_LOC(strtod_l, char, )
TEST_STRTO_FLOAT_LOC(strtold_l, char, )		TEST_STRTO_FLOAT_LOC(strtold_l, char, )
▲ Show 20 Lines • Show All 2,815 Lines • Show Last 20 Lines