This is an archive of the discontinued LLVM Phabricator instance.

[Polly] update to latest clang-format. [NFC]
ClosedPublic

Authored by bollu on Dec 4 2017, 8:32 AM.

Download Raw Diff

Details

Reviewers

grosser
philip.pfaffe
Meinersbur

Commits

rGc0f5f4deae0d: Update to latest clang-format. [NFC]
rPLO319718: Update to latest clang-format. [NFC]
rL319718: Update to latest clang-format. [NFC]

Diff Detail

Repository: rL LLVM

Event Timeline

bollu created this revision.Dec 4 2017, 8:32 AM

Herald added a subscriber: llvm-commits. · View Herald TranscriptDec 4 2017, 8:32 AM

bollu added reviewers: grosser, philip.pfaffe, Meinersbur.Dec 4 2017, 8:32 AM

bollu added a project: Restricted Project.

LGTM.

Do you know which revision/changes in clang-format caused this?

This revision is now accepted and ready to land.Dec 4 2017, 2:47 PM

No, unfortunately, I'm not sure. I didn't want to guess, so I didn't write a particular clang revision.

Closed by commit rL319718: Update to latest clang-format. [NFC] (authored by bollu). · Explain WhyDec 4 2017, 4:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

polly/

trunk/

lib/

Analysis/

ScopDetection.cpp

6 lines

Diff 125439

polly/trunk/lib/Analysis/ScopDetection.cpp

	Show First 20 Lines • Show All 1,361 Lines • ▼ Show 20 Lines
	Region *ScopDetection::expandRegion(Region &R) {			Region *ScopDetection::expandRegion(Region &R) {
	// Initial no valid region was found (greater than R)			// Initial no valid region was found (greater than R)
	std::unique_ptr<Region> LastValidRegion;			std::unique_ptr<Region> LastValidRegion;
	auto ExpandedRegion = std::unique_ptr<Region>(R.getExpandedRegion());			auto ExpandedRegion = std::unique_ptr<Region>(R.getExpandedRegion());

	DEBUG(dbgs() << "\tExpanding " << R.getNameStr() << "\n");			DEBUG(dbgs() << "\tExpanding " << R.getNameStr() << "\n");

	while (ExpandedRegion) {			while (ExpandedRegion) {
	const auto &It = DetectionContextMap.insert(			const auto &It = DetectionContextMap.insert(std::make_pair(
	std::make_pair(getBBPairForRegion(ExpandedRegion.get()),			getBBPairForRegion(ExpandedRegion.get()),
	DetectionContext(ExpandedRegion, AA, false /verifying*/)));			DetectionContext(ExpandedRegion, AA, false /verifying*/)));
	DetectionContext &Context = It.first->second;			DetectionContext &Context = It.first->second;
	DEBUG(dbgs() << "\t\tTrying " << ExpandedRegion->getNameStr() << "\n");			DEBUG(dbgs() << "\t\tTrying " << ExpandedRegion->getNameStr() << "\n");
	// Only expand when we did not collect errors.			// Only expand when we did not collect errors.

	if (!Context.Log.hasErrors()) {			if (!Context.Log.hasErrors()) {
	// If the exit is valid check all blocks			// If the exit is valid check all blocks
	// - if true, a valid region was found => store it + keep expanding			// - if true, a valid region was found => store it + keep expanding
	// - if false, .tbd. => stop (should this really end the loop?)			// - if false, .tbd. => stop (should this really end the loop?)
	▲ Show 20 Lines • Show All 523 Lines • Show Last 20 Lines