Page MenuHomePhabricator

[MS] Fix __movs intrinsics
Needs ReviewPublic

Authored by rnk on Nov 30 2017, 3:15 PM.

Details

Summary

These were incorrectly updated in r290539.

Event Timeline

rnk created this revision.Nov 30 2017, 3:15 PM
ahatanak edited edge metadata.Nov 30 2017, 9:41 PM

The changes in intrin.h look good.

Is it possible to add a test?

dolson added a subscriber: dolson.Dec 1 2017, 9:31 AM

Not a reviewer, but Re: https://reviews.llvm.org/D15075#940711 the changes in this review are identical to the ones I made locally yesterday and they resolved my problem with bad code generation. TYVM

rnk added a comment.Dec 1 2017, 10:17 AM

The changes in intrin.h look good.

Is it possible to add a test?

The only meaningful test is an assembly generation test, so we'd have to bend the rules of the clang test suite. An IR test wouldn't be meaningful. I think it's worth bending the rules, and if you do too I'll add it.

ahatanak removed a subscriber: dolson.Dec 1 2017, 10:29 AM

I agree that the test should check the assembly instructions emitted are valid, so an assembly test makes sense.

vitalybuka resigned from this revision.Dec 8 2017, 3:56 PM