This is an archive of the discontinued LLVM Phabricator instance.

A few initializations to please Valgrind. NFC
AbandonedPublic

Authored by JesperAntonsson on Nov 30 2017, 5:16 AM.

Details

Reviewers
bjope
chandlerc
Summary

Three fairly trivial null initializations to avoid Valgrind complaints.

Diff Detail

Event Timeline

bjope added inline comments.Dec 6 2017, 7:12 AM
include/llvm/CodeGen/MachineOperand.h
193

Shouldn't we initialize TiedTo here as well?

194

I think it would look nicer if all these bools were initialized to false instead of 0.

Updated according to Bjorns suggestions: added TiedTo initializations and made bool args initialize to false instead of 0.

chandlerc requested changes to this revision.Dec 8 2017, 2:31 AM

If MSan doesn't complain about these, I'm inclined to leave them uninitialized. I'm not sure how valuable it is to workaround valgrind false-positives.

If MSan does complain, that's a different matter...

This revision now requires changes to proceed.Dec 8 2017, 2:31 AM
JesperAntonsson abandoned this revision.Sep 25 2019, 1:17 AM

Should have been abandoned a long time ago.