Page MenuHomePhabricator

Fix code completion crash with unresolved member expr and explicit base
Needs ReviewPublic

Authored by erikjv on Nov 30 2017, 1:32 AM.

Details

Summary

This is actually a failing assert. When doing object argument
initialization, it is valid to have e.g. 'this' as a base in a member
access expression (which is a prvalue). It's also possible to have a
scope specifier as part of the member expression, in which case a base
that is an actual lvalue gets wrapped in an ImplicitCastExpr, which in
turn is an rvalue.

Diff Detail

Event Timeline

erikjv created this revision.Nov 30 2017, 1:32 AM
nik added a subscriber: nik.Nov 30 2017, 1:38 AM