This is an archive of the discontinued LLVM Phabricator instance.

Simplify Symbol::copyFrom
ClosedPublic

Authored by • rafael on Nov 28 2017, 3:09 PM.

Reviewers

ruiu

Summary

This is only used for --wrap and I don't think these fields have a meaningful impact on that feature.

Then maybe we should just use memcpy?

Just use memcpy.

LGTM

This revision is now accepted and ready to land.Nov 28 2017, 3:41 PM

r319265

Path

Size

ELF/

8 lines

Show First 20 Lines • Show All 132 Lines • ▼ Show 20 Lines	InputFile *Symbol::getFile() const {
}		}
return File;		return File;
}		}

// Overwrites all attributes with Other's so that this symbol becomes		// Overwrites all attributes with Other's so that this symbol becomes
// an alias to Other. This is useful for handling some options such as		// an alias to Other. This is useful for handling some options such as
// --wrap.		// --wrap.
void Symbol::copyFrom(Symbol *Other) {		void Symbol::copyFrom(Symbol *Other) {
Symbol Sym = *this;
memcpy(this, Other, sizeof(SymbolUnion));		memcpy(this, Other, sizeof(SymbolUnion));

VersionId = Sym.VersionId;
IsUsedInRegularObj = Sym.IsUsedInRegularObj;
ExportDynamic = Sym.ExportDynamic;
CanInline = Sym.CanInline;
Traced = Sym.Traced;
InVersionScript = Sym.InVersionScript;
}		}

uint64_t Symbol::getVA(int64_t Addend) const {		uint64_t Symbol::getVA(int64_t Addend) const {
uint64_t OutVA = getSymVA(*this, Addend);		uint64_t OutVA = getSymVA(*this, Addend);
return OutVA + Addend;		return OutVA + Addend;
}		}

uint64_t Symbol::getGotVA() const { return InX::Got->getVA() + getGotOffset(); }		uint64_t Symbol::getGotVA() const { return InX::Got->getVA() + getGotOffset(); }
▲ Show 20 Lines • Show All 162 Lines • Show Last 20 Lines