This is an archive of the discontinued LLVM Phabricator instance.

[LibFuzzer] Improve comments on `CounterToFeature()` function.
ClosedPublic

Authored by delcypher on Nov 28 2017, 9:22 AM.

Details

Summary

This is based on discussion in https://reviews.llvm.org/D40376 .

The comments try to explain the reason for the current implementation
and note that it might change in the future, so clients should not
rely on this particular implementation.

Diff Detail

Repository
rL LLVM

Event Timeline

delcypher created this revision.Nov 28 2017, 9:22 AM
kcc accepted this revision.Nov 28 2017, 9:31 AM
kcc added a reviewer: morehouse.

LGTM, thanks!
Do you need us to land it?
If so, Matt will do it.

This revision is now accepted and ready to land.Nov 28 2017, 9:31 AM
In D40565#937827, @kcc wrote:

LGTM, thanks!
Do you need us to land it?
If so, Matt will do it.

I can commit this. By the way the code in this function isn't properly formatted. I decided not to change it in this patch though because I didn't want to mix the two things together.

This revision was automatically updated to reflect the committed changes.