Pass by reference NewQualifiedName in QualifiedRenameRule

[Quolyk]

Summary

Motivation: https://bugs.llvm.org/show_bug.cgi?id=35304

[hokein]

include/clang/Tooling/Refactoring/Rename/RenamingAction.h

79

Passing std::string object is fine here -- because we use std::move below to avoid the extra copy.

Is the warning caught by the clang-tidy check?

[Quolyk]

include/clang/Tooling/Refactoring/Rename/RenamingAction.h

79

Unfortunatelly, I haven't tested, but I believe it's checkcpp warning.

[hokein]

include/clang/Tooling/Refactoring/Rename/RenamingAction.h

79

I think this is a false positive of the checkcpp.

There is a similar clang-tidy "performance-unnecessary-value-param" check, but I don't think the check will warn this case.

include/clang/Tooling/Refactoring/Rename/RenamingAction.h

public:
   static Expected<QualifiedRenameRule> initiate(RefactoringRuleContext &Context,
                                                 std::string OldQualifiedName,
                                                 std::string NewQualifiedName);
 
   static const RefactoringDescriptor &describe();
 
 private:
   QualifiedRenameRule(const NamedDecl *ND,
-                      std::string NewQualifiedName)
+                      const std::string &NewQualifiedName)
       : ND(ND), NewQualifiedName(std::move(NewQualifiedName)) {}
 
   Expected<AtomicChanges>
   createSourceReplacements(RefactoringRuleContext &Context) override;
 
   // A NamedDecl which indentifies the the symbol being renamed.
   const NamedDecl *ND;
   // The new qualified name to change the symbol to.