Page MenuHomePhabricator

DWZ 08/12: DWARFCompileUnit::ExtractDIEsIfNeeded can now expand AllDiesButCuDieOnlyForPartialUnits
AbandonedPublic

Authored by jankratochvil on Nov 26 2017, 5:13 AM.

Details

Reviewers
clayborg
labath
Summary

It does not make sense to extract whole DW_TAG_partial_unit only to find out it is a partial unit and so it cannot be indexed on its own.

All DWZ patches are also applied in: git clone -b dwz git://git.jankratochvil.net/lldb

Diff Detail

Event Timeline

jankratochvil created this revision.Nov 26 2017, 5:13 AM
clayborg requested changes to this revision.Nov 27 2017, 10:44 AM

See inline comments.

source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
2050–2052

All of these changes can be avoided by just appropriately checking for partial units and skipping them in this index function. Do you plan on using this functionality in any other place? I would rather you just fix this function to filter out the partial units.

This revision now requires changes to proceed.Nov 27 2017, 10:44 AM
jankratochvil abandoned this revision.Feb 20 2018, 7:19 AM
jankratochvil marked an inline comment as done.