Move the implementation to its own file.
Details
Diff Detail
Event Timeline
LGTM, thanks. I'd commit the MachineOperand.h changes in a separate commit.
Feel free to do the doxygen comment cleanups in a separate future commit if you like.
lib/CodeGen/MachineOperand.cpp | ||
---|---|---|
10 | Use /// \file ... so doxygen can pick it up. | |
32–34 | This is unnecessary now as the whole file is about MachineOperand. | |
80 | As we are on it: Would be good to move the doxygen comments from the implementation to the header where possible. | |
113–115 | In cases where we have a doxygen comment in the implementation and the declaration we should just remove it from the implementation. |
llvm/trunk/lib/CodeGen/MachineOperand.cpp | ||
---|---|---|
10–11 ↗ | (On Diff #124598) | This should be: /// \file Methods common to all machine operands. (just look around some other files for examples). |
llvm/trunk/lib/CodeGen/MachineOperand.cpp | ||
---|---|---|
10–11 ↗ | (On Diff #124598) | Ok, fixed in r319206 (I actually did look around, but it looks like the version with a newline is more popular) |
Use /// \file ... so doxygen can pick it up.