This removes TODO added in http://reviews.llvm.org/D3658
The patch transforms
ABS(NABS(X)) -> ABS(X) NABS(ABS(X)) -> NABS(X)
Paths
| Differential D4040
Added transform for ABS(NABS(X)) and NABS(ABS(X)) ClosedPublic Authored by dinesh.d on Jun 6 2014, 12:53 AM.
Details Summary This removes TODO added in http://reviews.llvm.org/D3658 The patch transforms ABS(NABS(X)) -> ABS(X) NABS(ABS(X)) -> NABS(X)
Diff Detail Event Timelinedinesh.d updated this object. Comment Actions LGTM I wouldn't bother re-testing all the permutations of the 'icmp' representation -- that code should already be well tested by existing checks? Still, not a big deal, just trying to minimize the redundancy in the testing. This revision is now accepted and ready to land.Jun 12 2014, 5:19 AM Comment Actions Thanks, I had submitted similar patch [http://reviews.llvm.org/D3658] with all permutations of icmp. I am submitting it as it is. But if you care, I can remove few test cases for both changes.
Revision Contents
Diff 10166 lib/Transforms/InstCombine/InstCombineSelect.cpp
test/Transforms/InstCombine/abs_abs.ll
|