This is an archive of the discontinued LLVM Phabricator instance.

Differential D40356

Fix types of Fortran array elements
ClosedPublic

Authored by omalyshe on Nov 22 2017, 7:13 AM.

Details

Reviewers
jlpeyton
hbae
tlwilmar
Commits
rG92ce4bcfd848: Fix types of Fortran array elements
rOMP319372: Fix types of Fortran array elements
rL319372: Fix types of Fortran array elements
Summary

Fortran array elements made default integer in OMP_GET_PLACE_PROC_IDS and OMP_GET_PARTITION_PLACE_NUMS subroutines, otherwise call to them produces incorrect result.

Diff Detail

Repository
rL LLVM

Event Timeline

omalyshe created this revision.Nov 22 2017, 7:13 AM
hbae accepted this revision.Nov 27 2017, 2:21 PM

LGTM

This revision is now accepted and ready to land.Nov 27 2017, 2:21 PM
Closed by commit rL319372: Fix types of Fortran array elements (authored by jlpeyton). · Explain WhyNov 29 2017, 2:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
openmp/
trunk/
runtime/
src/
include/
45/
4 lines
4 lines
4 lines
50/
4 lines
4 lines
4 lines

Diff 124819

openmp/trunk/runtime/src/include/45/omp_lib.h.var

Show First 20 Lines • Show All 180 Lines • ▼ Show 20 Lines! ***
import import
integer (kind=omp_integer_kind), value :: place_num integer (kind=omp_integer_kind), value :: place_num
integer (kind=omp_integer_kind) omp_get_place_num_procs integer (kind=omp_integer_kind) omp_get_place_num_procs
end function omp_get_place_num_procs end function omp_get_place_num_procs
subroutine omp_get_place_proc_ids(place_num, ids) bind(c) subroutine omp_get_place_proc_ids(place_num, ids) bind(c)
import import
integer (kind=omp_integer_kind), value :: place_num integer (kind=omp_integer_kind), value :: place_num
integer (kind=kmp_pointer_kind) ids(*) integer (kind=omp_integer_kind) ids(*)
end subroutine omp_get_place_proc_ids end subroutine omp_get_place_proc_ids
function omp_get_place_num() bind(c) function omp_get_place_num() bind(c)
import import
integer (kind=omp_integer_kind) omp_get_place_num integer (kind=omp_integer_kind) omp_get_place_num
end function omp_get_place_num end function omp_get_place_num
function omp_get_partition_num_places() bind(c) function omp_get_partition_num_places() bind(c)
import import
integer (kind=omp_integer_kind) omp_get_partition_num_places integer (kind=omp_integer_kind) omp_get_partition_num_places
end function omp_get_partition_num_places end function omp_get_partition_num_places
subroutine omp_get_partition_place_nums(place_nums) bind(c) subroutine omp_get_partition_place_nums(place_nums) bind(c)
import import
integer (kind=kmp_pointer_kind) place_nums(*) integer (kind=omp_integer_kind) place_nums(*)
end subroutine omp_get_partition_place_nums end subroutine omp_get_partition_place_nums
function omp_get_wtime() bind(c) function omp_get_wtime() bind(c)
double precision omp_get_wtime double precision omp_get_wtime
end function omp_get_wtime end function omp_get_wtime
function omp_get_wtick() bind(c) function omp_get_wtick() bind(c)
double precision omp_get_wtick double precision omp_get_wtick
▲ Show 20 Lines • Show All 432 Lines • Show Last 20 Lines

openmp/trunk/runtime/src/include/45/omp_lib.f.var

Show First 20 Lines • Show All 193 Lines • ▼ Show 20 Lines! ***
use omp_lib_kinds use omp_lib_kinds
integer (kind=omp_integer_kind) place_num integer (kind=omp_integer_kind) place_num
integer (kind=omp_integer_kind) omp_get_place_num_procs integer (kind=omp_integer_kind) omp_get_place_num_procs
end function omp_get_place_num_procs end function omp_get_place_num_procs
subroutine omp_get_place_proc_ids(place_num, ids) subroutine omp_get_place_proc_ids(place_num, ids)
use omp_lib_kinds use omp_lib_kinds
integer (kind=omp_integer_kind) place_num integer (kind=omp_integer_kind) place_num
integer (kind=kmp_pointer_kind) ids(*) integer (kind=omp_integer_kind) ids(*)
end subroutine omp_get_place_proc_ids end subroutine omp_get_place_proc_ids
function omp_get_place_num() function omp_get_place_num()
use omp_lib_kinds use omp_lib_kinds
integer (kind=omp_integer_kind) omp_get_place_num integer (kind=omp_integer_kind) omp_get_place_num
end function omp_get_place_num end function omp_get_place_num
function omp_get_partition_num_places() function omp_get_partition_num_places()
use omp_lib_kinds use omp_lib_kinds
integer (kind=omp_integer_kind) omp_get_partition_num_places integer (kind=omp_integer_kind) omp_get_partition_num_places
end function omp_get_partition_num_places end function omp_get_partition_num_places
subroutine omp_get_partition_place_nums(place_nums) subroutine omp_get_partition_place_nums(place_nums)
use omp_lib_kinds use omp_lib_kinds
integer (kind=kmp_pointer_kind) place_nums(*) integer (kind=omp_integer_kind) place_nums(*)
end subroutine omp_get_partition_place_nums end subroutine omp_get_partition_place_nums
function omp_get_wtime() function omp_get_wtime()
double precision omp_get_wtime double precision omp_get_wtime
end function omp_get_wtime end function omp_get_wtime
function omp_get_wtick () function omp_get_wtick ()
double precision omp_get_wtick double precision omp_get_wtick
▲ Show 20 Lines • Show All 630 Lines • Show Last 20 Lines

openmp/trunk/runtime/src/include/45/omp_lib.f90.var

Show First 20 Lines • Show All 191 Lines • ▼ Show 20 Lines! ***
use omp_lib_kinds use omp_lib_kinds
integer (kind=omp_integer_kind), value :: place_num integer (kind=omp_integer_kind), value :: place_num
integer (kind=omp_integer_kind) omp_get_place_num_procs integer (kind=omp_integer_kind) omp_get_place_num_procs
end function omp_get_place_num_procs end function omp_get_place_num_procs
subroutine omp_get_place_proc_ids(place_num, ids) bind(c) subroutine omp_get_place_proc_ids(place_num, ids) bind(c)
use omp_lib_kinds use omp_lib_kinds
integer (kind=omp_integer_kind), value :: place_num integer (kind=omp_integer_kind), value :: place_num
integer (kind=kmp_pointer_kind) ids(*) integer (kind=omp_integer_kind) ids(*)
end subroutine omp_get_place_proc_ids end subroutine omp_get_place_proc_ids
function omp_get_place_num() bind(c) function omp_get_place_num() bind(c)
use omp_lib_kinds use omp_lib_kinds
integer (kind=omp_integer_kind) omp_get_place_num integer (kind=omp_integer_kind) omp_get_place_num
end function omp_get_place_num end function omp_get_place_num
function omp_get_partition_num_places() bind(c) function omp_get_partition_num_places() bind(c)
use omp_lib_kinds use omp_lib_kinds
integer (kind=omp_integer_kind) omp_get_partition_num_places integer (kind=omp_integer_kind) omp_get_partition_num_places
end function omp_get_partition_num_places end function omp_get_partition_num_places
subroutine omp_get_partition_place_nums(place_nums) bind(c) subroutine omp_get_partition_place_nums(place_nums) bind(c)
use omp_lib_kinds use omp_lib_kinds
integer (kind=kmp_pointer_kind) place_nums(*) integer (kind=omp_integer_kind) place_nums(*)
end subroutine omp_get_partition_place_nums end subroutine omp_get_partition_place_nums
function omp_get_wtime() bind(c) function omp_get_wtime() bind(c)
use omp_lib_kinds use omp_lib_kinds
real (kind=kmp_double_kind) omp_get_wtime real (kind=kmp_double_kind) omp_get_wtime
end function omp_get_wtime end function omp_get_wtime
function omp_get_wtick() bind(c) function omp_get_wtick() bind(c)
▲ Show 20 Lines • Show All 301 Lines • Show Last 20 Lines

openmp/trunk/runtime/src/include/50/omp_lib.h.var

Show First 20 Lines • Show All 192 Lines • ▼ Show 20 Lines! ***
import import
integer (kind=omp_integer_kind), value :: place_num integer (kind=omp_integer_kind), value :: place_num
integer (kind=omp_integer_kind) omp_get_place_num_procs integer (kind=omp_integer_kind) omp_get_place_num_procs
end function omp_get_place_num_procs end function omp_get_place_num_procs
subroutine omp_get_place_proc_ids(place_num, ids) bind(c) subroutine omp_get_place_proc_ids(place_num, ids) bind(c)
import import
integer (kind=omp_integer_kind), value :: place_num integer (kind=omp_integer_kind), value :: place_num
integer (kind=kmp_pointer_kind) ids(*) integer (kind=omp_integer_kind) ids(*)
end subroutine omp_get_place_proc_ids end subroutine omp_get_place_proc_ids
function omp_get_place_num() bind(c) function omp_get_place_num() bind(c)
import import
integer (kind=omp_integer_kind) omp_get_place_num integer (kind=omp_integer_kind) omp_get_place_num
end function omp_get_place_num end function omp_get_place_num
function omp_get_partition_num_places() bind(c) function omp_get_partition_num_places() bind(c)
import import
integer (kind=omp_integer_kind) omp_get_partition_num_places integer (kind=omp_integer_kind) omp_get_partition_num_places
end function omp_get_partition_num_places end function omp_get_partition_num_places
subroutine omp_get_partition_place_nums(place_nums) bind(c) subroutine omp_get_partition_place_nums(place_nums) bind(c)
import import
integer (kind=kmp_pointer_kind) place_nums(*) integer (kind=omp_integer_kind) place_nums(*)
end subroutine omp_get_partition_place_nums end subroutine omp_get_partition_place_nums
function omp_get_wtime() bind(c) function omp_get_wtime() bind(c)
double precision omp_get_wtime double precision omp_get_wtime
end function omp_get_wtime end function omp_get_wtime
function omp_get_wtick() bind(c) function omp_get_wtick() bind(c)
double precision omp_get_wtick double precision omp_get_wtick
▲ Show 20 Lines • Show All 439 Lines • Show Last 20 Lines

openmp/trunk/runtime/src/include/50/omp_lib.f.var

Show First 20 Lines • Show All 195 Lines • ▼ Show 20 Lines! ***
use omp_lib_kinds use omp_lib_kinds
integer (kind=omp_integer_kind) place_num integer (kind=omp_integer_kind) place_num
integer (kind=omp_integer_kind) omp_get_place_num_procs integer (kind=omp_integer_kind) omp_get_place_num_procs
end function omp_get_place_num_procs end function omp_get_place_num_procs
subroutine omp_get_place_proc_ids(place_num, ids) subroutine omp_get_place_proc_ids(place_num, ids)
use omp_lib_kinds use omp_lib_kinds
integer (kind=omp_integer_kind) place_num integer (kind=omp_integer_kind) place_num
integer (kind=kmp_pointer_kind) ids(*) integer (kind=omp_integer_kind) ids(*)
end subroutine omp_get_place_proc_ids end subroutine omp_get_place_proc_ids
function omp_get_place_num() function omp_get_place_num()
use omp_lib_kinds use omp_lib_kinds
integer (kind=omp_integer_kind) omp_get_place_num integer (kind=omp_integer_kind) omp_get_place_num
end function omp_get_place_num end function omp_get_place_num
function omp_get_partition_num_places() function omp_get_partition_num_places()
use omp_lib_kinds use omp_lib_kinds
integer (kind=omp_integer_kind) omp_get_partition_num_places integer (kind=omp_integer_kind) omp_get_partition_num_places
end function omp_get_partition_num_places end function omp_get_partition_num_places
subroutine omp_get_partition_place_nums(place_nums) subroutine omp_get_partition_place_nums(place_nums)
use omp_lib_kinds use omp_lib_kinds
integer (kind=kmp_pointer_kind) place_nums(*) integer (kind=omp_integer_kind) place_nums(*)
end subroutine omp_get_partition_place_nums end subroutine omp_get_partition_place_nums
function omp_get_wtime() function omp_get_wtime()
double precision omp_get_wtime double precision omp_get_wtime
end function omp_get_wtime end function omp_get_wtime
function omp_get_wtick () function omp_get_wtick ()
double precision omp_get_wtick double precision omp_get_wtick
▲ Show 20 Lines • Show All 641 Lines • Show Last 20 Lines

openmp/trunk/runtime/src/include/50/omp_lib.f90.var

Show First 20 Lines • Show All 203 Lines • ▼ Show 20 Lines! ***
use omp_lib_kinds use omp_lib_kinds
integer (kind=omp_integer_kind), value :: place_num integer (kind=omp_integer_kind), value :: place_num
integer (kind=omp_integer_kind) omp_get_place_num_procs integer (kind=omp_integer_kind) omp_get_place_num_procs
end function omp_get_place_num_procs end function omp_get_place_num_procs
subroutine omp_get_place_proc_ids(place_num, ids) bind(c) subroutine omp_get_place_proc_ids(place_num, ids) bind(c)
use omp_lib_kinds use omp_lib_kinds
integer (kind=omp_integer_kind), value :: place_num integer (kind=omp_integer_kind), value :: place_num
integer (kind=kmp_pointer_kind) ids(*) integer (kind=omp_integer_kind) ids(*)
end subroutine omp_get_place_proc_ids end subroutine omp_get_place_proc_ids
function omp_get_place_num() bind(c) function omp_get_place_num() bind(c)
use omp_lib_kinds use omp_lib_kinds
integer (kind=omp_integer_kind) omp_get_place_num integer (kind=omp_integer_kind) omp_get_place_num
end function omp_get_place_num end function omp_get_place_num
function omp_get_partition_num_places() bind(c) function omp_get_partition_num_places() bind(c)
use omp_lib_kinds use omp_lib_kinds
integer (kind=omp_integer_kind) omp_get_partition_num_places integer (kind=omp_integer_kind) omp_get_partition_num_places
end function omp_get_partition_num_places end function omp_get_partition_num_places
subroutine omp_get_partition_place_nums(place_nums) bind(c) subroutine omp_get_partition_place_nums(place_nums) bind(c)
use omp_lib_kinds use omp_lib_kinds
integer (kind=kmp_pointer_kind) place_nums(*) integer (kind=omp_integer_kind) place_nums(*)
end subroutine omp_get_partition_place_nums end subroutine omp_get_partition_place_nums
function omp_get_wtime() bind(c) function omp_get_wtime() bind(c)
use omp_lib_kinds use omp_lib_kinds
real (kind=kmp_double_kind) omp_get_wtime real (kind=kmp_double_kind) omp_get_wtime
end function omp_get_wtime end function omp_get_wtime
function omp_get_wtick() bind(c) function omp_get_wtick() bind(c)
▲ Show 20 Lines • Show All 308 Lines • Show Last 20 Lines