This is an archive of the discontinued LLVM Phabricator instance.

[utils][mips] Add support for mips for update_llc_checks.py
ClosedPublic

Authored by sdardis on Nov 20 2017, 1:47 PM.

Download Raw Diff

Details

Reviewers

Commits

rG9d6856526240: [utils][mips] Add support for mips for update_llc_checks.py
rL319001: [utils][mips] Add support for mips for update_llc_checks.py

Summary

Add support for mips, particularly skipping the matching of .frame, .(f)mask
and LLVM's usage of the .set no(reorder|at|macro) directives.

Diff Detail

Build Status

Buildable 12338
Build 12338: arc lint + arc unit

Event Timeline

sdardis created this revision.Nov 20 2017, 1:47 PM

Herald added a subscriber: arichardson. · View Herald TranscriptNov 20 2017, 1:47 PM

LGTM.

I'm not an expert on python or MIPS, so feel free to make changes as needed to make this script work. Glad to see more targets using this!

This revision is now accepted and ready to land.Nov 26 2017, 9:45 AM

sdardis retitled this revision from [utils, mips] Add support for mips for update_llc_checks.py to [utils][mips] Add support for mips for update_llc_checks.py.Nov 26 2017, 11:18 AM

sdardis edited the summary of this revision. (Show Details)

Closed by commit rL319001: [utils][mips] Add support for mips for update_llc_checks.py (authored by sdardis). · Explain WhyNov 26 2017, 11:23 AM

This revision was automatically updated to reflect the committed changes.

Thanks for the review.

Revision Contents

Path

Size

utils/

update_llc_test_checks.py

20 lines

Diff 123650

utils/update_llc_test_checks.py

Show First 20 Lines • Show All 41 Lines • ▼ Show 20 Lines
ASM_FUNCTION_AARCH64_RE = re.compile(		ASM_FUNCTION_AARCH64_RE = re.compile(
r'^_?(?P<func>[^:]+):[ \t]\/\/[ \t]@(?P=func)\n'		r'^_?(?P<func>[^:]+):[ \t]\/\/[ \t]@(?P=func)\n'
r'[ \t]+.cfi_startproc\n'		r'[ \t]+.cfi_startproc\n'
r'(?P<body>.*?)\n'		r'(?P<body>.*?)\n'
# This list is incomplete		# This list is incomplete
r'.Lfunc_end[0-9]+:\n',		r'.Lfunc_end[0-9]+:\n',
flags=(re.M \| re.S))		flags=(re.M \| re.S))

		ASM_FUNCTION_MIPS_RE = re.compile(
		r'^_?(?P<func>[^:]+):[ \t]#+[ \t]@(?P=func)\n[^:]*?' # f: (name of func)
		r'(?:^[ \t]+\.(frame\|f?mask\|set).*?\n)+' # Mips+LLVM standard asm prologue
		r'(?P<body>.*?)\n' # (body of the function)
		r'(?:^[ \t]+\.(set\|end).*?\n)+' # Mips+LLVM stanard asm epilogue
		r'(\$\|\.L)func_end[0-9]+:\n', # $func_end0: (mips32 - O32) or
		# .Lfunc_end0: (mips64 - NewABI)
		flags=(re.M \| re.S))

ASM_FUNCTION_PPC_RE = re.compile(		ASM_FUNCTION_PPC_RE = re.compile(
r'^_?(?P<func>[^:]+):[ \t]#+[ \t]@(?P=func)\n'		r'^_?(?P<func>[^:]+):[ \t]#+[ \t]@(?P=func)\n'
r'\.Lfunc_begin[0-9]+:\n'		r'\.Lfunc_begin[0-9]+:\n'
r'[ \t]+.cfi_startproc\n'		r'[ \t]+.cfi_startproc\n'
r'(?:\.Lfunc_[gl]ep[0-9]+:\n(?:[ \t]+.?\n))*'		r'(?:\.Lfunc_[gl]ep[0-9]+:\n(?:[ \t]+.?\n))*'
r'(?P<body>.*?)\n'		r'(?P<body>.*?)\n'
# This list is incomplete		# This list is incomplete
r'(?:^[ \t](?:\.long[ \t]+[^\n]+\|\.quad[ \t]+[^\n]+)\n)'		r'(?:^[ \t](?:\.long[ \t]+[^\n]+\|\.quad[ \t]+[^\n]+)\n)'
▲ Show 20 Lines • Show All 78 Lines • ▼ Show 20 Lines	def scrub_asm_powerpc64(asm, args):
# Expand the tabs used for indentation.		# Expand the tabs used for indentation.
asm = string.expandtabs(asm, 2)		asm = string.expandtabs(asm, 2)
# Stripe unimportant comments		# Stripe unimportant comments
asm = SCRUB_LOOP_COMMENT_RE.sub(r'', asm)		asm = SCRUB_LOOP_COMMENT_RE.sub(r'', asm)
# Strip trailing whitespace.		# Strip trailing whitespace.
asm = SCRUB_TRAILING_WHITESPACE_RE.sub(r'', asm)		asm = SCRUB_TRAILING_WHITESPACE_RE.sub(r'', asm)
return asm		return asm

		def scrub_asm_mips(asm, args):
		# Scrub runs of whitespace out of the assembly, but leave the leading
		# whitespace in place.
		asm = SCRUB_WHITESPACE_RE.sub(r' ', asm)
		# Expand the tabs used for indentation.
		asm = string.expandtabs(asm, 2)
		# Strip trailing whitespace.
		asm = SCRUB_TRAILING_WHITESPACE_RE.sub(r'', asm)
		return asm

def scrub_asm_riscv(asm, args):		def scrub_asm_riscv(asm, args):
# Scrub runs of whitespace out of the assembly, but leave the leading		# Scrub runs of whitespace out of the assembly, but leave the leading
# whitespace in place.		# whitespace in place.
asm = SCRUB_WHITESPACE_RE.sub(r' ', asm)		asm = SCRUB_WHITESPACE_RE.sub(r' ', asm)
# Expand the tabs used for indentation.		# Expand the tabs used for indentation.
asm = string.expandtabs(asm, 2)		asm = string.expandtabs(asm, 2)
# Strip trailing whitespace.		# Strip trailing whitespace.
asm = SCRUB_TRAILING_WHITESPACE_RE.sub(r'', asm)		asm = SCRUB_TRAILING_WHITESPACE_RE.sub(r'', asm)
Show All 18 Lines	target_handlers = {
'i686': (scrub_asm_x86, ASM_FUNCTION_X86_RE),		'i686': (scrub_asm_x86, ASM_FUNCTION_X86_RE),
'x86': (scrub_asm_x86, ASM_FUNCTION_X86_RE),		'x86': (scrub_asm_x86, ASM_FUNCTION_X86_RE),
'i386': (scrub_asm_x86, ASM_FUNCTION_X86_RE),		'i386': (scrub_asm_x86, ASM_FUNCTION_X86_RE),
'aarch64': (scrub_asm_arm_eabi, ASM_FUNCTION_AARCH64_RE),		'aarch64': (scrub_asm_arm_eabi, ASM_FUNCTION_AARCH64_RE),
'arm-eabi': (scrub_asm_arm_eabi, ASM_FUNCTION_ARM_RE),		'arm-eabi': (scrub_asm_arm_eabi, ASM_FUNCTION_ARM_RE),
'thumb-eabi': (scrub_asm_arm_eabi, ASM_FUNCTION_ARM_RE),		'thumb-eabi': (scrub_asm_arm_eabi, ASM_FUNCTION_ARM_RE),
'thumbv8-eabi': (scrub_asm_arm_eabi, ASM_FUNCTION_ARM_RE),		'thumbv8-eabi': (scrub_asm_arm_eabi, ASM_FUNCTION_ARM_RE),
'armeb-eabi': (scrub_asm_arm_eabi, ASM_FUNCTION_ARM_RE),		'armeb-eabi': (scrub_asm_arm_eabi, ASM_FUNCTION_ARM_RE),
		'mips': (scrub_asm_mips, ASM_FUNCTION_MIPS_RE),
'powerpc64': (scrub_asm_powerpc64, ASM_FUNCTION_PPC_RE),		'powerpc64': (scrub_asm_powerpc64, ASM_FUNCTION_PPC_RE),
'powerpc64le': (scrub_asm_powerpc64, ASM_FUNCTION_PPC_RE),		'powerpc64le': (scrub_asm_powerpc64, ASM_FUNCTION_PPC_RE),
'riscv32': (scrub_asm_riscv, ASM_FUNCTION_RISCV_RE),		'riscv32': (scrub_asm_riscv, ASM_FUNCTION_RISCV_RE),
'riscv64': (scrub_asm_riscv, ASM_FUNCTION_RISCV_RE),		'riscv64': (scrub_asm_riscv, ASM_FUNCTION_RISCV_RE),
's390x': (scrub_asm_systemz, ASM_FUNCTION_SYSTEMZ_RE),		's390x': (scrub_asm_systemz, ASM_FUNCTION_SYSTEMZ_RE),
}		}
handlers = None		handlers = None
for prefix, s in target_handlers.items():		for prefix, s in target_handlers.items():
▲ Show 20 Lines • Show All 221 Lines • Show Last 20 Lines