[CMake] Add LLVM_ENABLE_IDE option to better process sources for IDE's

[EricWF]

Summary

Currently LLVM has no way to support configuring for IDE's like CLion. Like XCode and MSVC's IDE, CLion needs to see all of the headers and tablegen files in order to properly parse the sources.

This patch adds an LLVM_ENABLE_IDE option which can be used to configure for IDE's in general. It is used by LLVMProcessSources.cmake to determine if the extra source files should be added to the target.

Unfortunately because of the low level of LLVMProcessSources.cmake, I'm not sure where the LLVM_ENABLE_IDE option should live. I choose HandleLLVMOptions.cmake so that out-of-tree Clang builds would correctly configure the option by default.

[lebedev.ri]

Looks good to me, but i have no prior involvement in llvm cmake build system so i'm not sure i can/should Accept this Revision.

cmake/modules/HandleLLVMOptions.cmake

853

When using qtcreator, which results in extra generator being used, the LLVM_ENABLE_IDE option is correctly default-on, which is great.

cmake/modules/LLVMProcessSources.cmake

55

Or do we want to rely on LLVM_ENABLE_IDE?

[beanz]

One comment below. Otherwise LGTM.

cmake/modules/LLVMProcessSources.cmake

55

This should just be if(LLVM_ENABLE_IDE) because MSVC_IDE and XCODE are checked when setting the default for that variable.

[EricWF]

• Address inline comments.

cmake/modules/HandleLLVMOptions.cmake

if(BUILD_SHARED_LIBS OR LLVM_BUILD_LLVM_DYLIB)
     set(LLVM_ENABLE_PLUGINS ON)
   else()
     set(LLVM_ENABLE_PLUGINS OFF)
   endif()
 else()
   set(LLVM_ENABLE_PLUGINS ON)
 endif()
 
+set(LLVM_ENABLE_IDE_default OFF)
+if (XCODE OR MSVC_IDE OR CMAKE_EXTRA_GENERATOR)
+  set(LLVM_ENABLE_IDE_default ON)
+endif()
+option(LLVM_ENABLE_IDE "Generate targets and process sources for use with an IDE"
+    ${LLVM_ENABLE_IDE_default})
+
 function(get_compile_definitions)
   get_directory_property(top_dir_definitions DIRECTORY ${CMAKE_SOURCE_DIR} COMPILE_DEFINITIONS)
   foreach(definition ${top_dir_definitions})
     if(DEFINED result)
       string(APPEND result " -D${definition}")
     else()
       set(result "-D${definition}")
     endif()
   endforeach()
   set(LLVM_DEFINITIONS "${result}" PARENT_SCOPE)
 endfunction()
 get_compile_definitions()

cmake/modules/LLVMProcessSources.cmake

function(find_all_header_files hdrs_out additional_headerdirs)
   set( ${hdrs_out} ${all_headers} PARENT_SCOPE )
 endfunction(find_all_header_files)
 
 
 function(llvm_process_sources OUT_VAR)
   cmake_parse_arguments(ARG "" "" "ADDITIONAL_HEADERS;ADDITIONAL_HEADER_DIRS" ${ARGN})
   set(sources ${ARG_UNPARSED_ARGUMENTS})
   llvm_check_source_file_list( ${sources} )
-  if( MSVC_IDE OR XCODE )
+  if( LLVM_ENABLE_IDE )
     # This adds .td and .h files to the Visual Studio solution:
     add_td_sources(sources)
     find_all_header_files(hdrs "${ARG_ADDITIONAL_HEADER_DIRS}")
     if (hdrs)
       set_source_files_properties(${hdrs} PROPERTIES HEADER_FILE_ONLY ON)
     endif()
     set_source_files_properties(${ARG_ADDITIONAL_HEADERS} PROPERTIES HEADER_FILE_ONLY ON)
     list(APPEND sources ${ARG_ADDITIONAL_HEADERS} ${hdrs})