This is an archive of the discontinued LLVM Phabricator instance.

llvm-demangle-fuzzer: Link in Support
ClosedPublic

Authored by Hahnfeld on Nov 17 2017, 11:56 AM.

Download Raw Diff

Details

Reviewers

igor-laevsky
kongyi

Commits

rGc6b7af2b4d00: llvm-demangle-fuzzer: Link in Support
rL318553: llvm-demangle-fuzzer: Link in Support

Summary

The refactoring in rL318407 transiently includes abi-breaking.h
which defines EnableABIBreakingChecks. This breaks my Debug
build because this fuzzer did not link in Support with the symbol.

Diff Detail

Event Timeline

Hahnfeld created this revision.Nov 17 2017, 11:56 AM

Herald added a subscriber: mgorny. · View Herald TranscriptNov 17 2017, 11:56 AM

Hahnfeld mentioned this in rL318409: [FuzzMutate] Fix windows build after rL318407..Nov 17 2017, 11:57 AM

LGTM, thanks for fixing this.

This revision is now accepted and ready to land.Nov 17 2017, 12:38 PM

Closed by commit rL318553: llvm-demangle-fuzzer: Link in Support (authored by Hahnfeld). · Explain WhyNov 17 2017, 12:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

tools/

llvm-demangle-fuzzer/

CMakeLists.txt

1 line

Diff 123393

tools/llvm-demangle-fuzzer/CMakeLists.txt

	set(LLVM_LINK_COMPONENTS			set(LLVM_LINK_COMPONENTS
	Demangle			Demangle
	FuzzMutate			FuzzMutate
				Support
	)			)

	add_llvm_fuzzer(llvm-demangle-fuzzer			add_llvm_fuzzer(llvm-demangle-fuzzer
	llvm-demangle-fuzzer.cpp			llvm-demangle-fuzzer.cpp
	DUMMY_MAIN DummyDemanglerFuzzer.cpp)			DUMMY_MAIN DummyDemanglerFuzzer.cpp)