This is an archive of the discontinued LLVM Phabricator instance.

COFF: Stop emitting a non-standard COFF symbol table into PEs.
ClosedPublic

Authored by pcc on Nov 17 2017, 11:23 AM.

Details

Summary

Now that our support for PDB is reasonably good, there is no longer
a need to emit a COFF symbol table.

Also fix a bug where we would fail to emit a string table for long
section names if /debug was not specified.

Depends on D40188

Diff Detail

Repository
rL LLVM

Event Timeline

pcc created this revision.Nov 17 2017, 11:23 AM
pcc updated this revision to Diff 123386.Nov 17 2017, 11:25 AM
  • Remove some debugging code
rnk accepted this revision.Nov 17 2017, 11:30 AM

lgtm

This revision is now accepted and ready to land.Nov 17 2017, 11:30 AM
This revision was automatically updated to reflect the committed changes.
ruiu edited edge metadata.Nov 17 2017, 9:18 PM

LGTM

lld/trunk/test/COFF/strtab-size.s