This is an archive of the discontinued LLVM Phabricator instance.

Differential D40120

[clang-format] Add text proto filename detection
ClosedPublic

Authored by krasimir on Nov 16 2017, 3:40 AM.

Details

Reviewers
klimek
Commits
rG6649665d5a16: [clang-format] Add text proto filename detection
rC318525: [clang-format] Add text proto filename detection
rL318525: [clang-format] Add text proto filename detection
Summary

Adds text proto filename detection.

Diff Detail

Event Timeline

krasimir created this revision.Nov 16 2017, 3:40 AM
klimek edited edge metadata.Nov 16 2017, 4:49 AM

Should that be configured? METADATA seems pretty domain specific ;)

krasimir updated this revision to Diff 123308.Nov 17 2017, 2:25 AM
  • Remove METADATA
Harbormaster completed remote builds in B12268: Diff 123308.Nov 17 2017, 2:25 AM
klimek accepted this revision.Nov 17 2017, 6:36 AM

LG

This revision is now accepted and ready to land.Nov 17 2017, 6:36 AM
Closed by commit rL318525: [clang-format] Add text proto filename detection (authored by krasimir). · Explain WhyNov 17 2017, 7:10 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Format/
5 lines

Diff 123153

lib/Format/Format.cpp

Show First 20 Lines • Show All 2,078 Lines • ▼ Show 20 Lines if (FileName.endswith(".java"))
return FormatStyle::LK_Java; return FormatStyle::LK_Java;
if (FileName.endswith_lower(".js") || FileName.endswith_lower(".ts")) if (FileName.endswith_lower(".js") || FileName.endswith_lower(".ts"))
return FormatStyle::LK_JavaScript; // JavaScript or TypeScript. return FormatStyle::LK_JavaScript; // JavaScript or TypeScript.
if (FileName.endswith(".m") || FileName.endswith(".mm")) if (FileName.endswith(".m") || FileName.endswith(".mm"))
return FormatStyle::LK_ObjC; return FormatStyle::LK_ObjC;
if (FileName.endswith_lower(".proto") || if (FileName.endswith_lower(".proto") ||
FileName.endswith_lower(".protodevel")) FileName.endswith_lower(".protodevel"))
return FormatStyle::LK_Proto; return FormatStyle::LK_Proto;
if (FileName.endswith_lower(".textpb") ||
FileName.endswith_lower(".pb.txt") ||
FileName.endswith_lower(".textproto") ||
FileName.endswith_lower(".asciipb") || FileName.endswith("METADATA"))
return FormatStyle::LK_TextProto;
if (FileName.endswith_lower(".td")) if (FileName.endswith_lower(".td"))
return FormatStyle::LK_TableGen; return FormatStyle::LK_TableGen;
return FormatStyle::LK_Cpp; return FormatStyle::LK_Cpp;
} }
llvm::Expected<FormatStyle> getStyle(StringRef StyleName, StringRef FileName, llvm::Expected<FormatStyle> getStyle(StringRef StyleName, StringRef FileName,
StringRef FallbackStyleName, StringRef FallbackStyleName,
StringRef Code, vfs::FileSystem *FS) { StringRef Code, vfs::FileSystem *FS) {
▲ Show 20 Lines • Show All 92 Lines • Show Last 20 Lines