This is an archive of the discontinued LLVM Phabricator instance.

[msan] Extract signal_impl and sigaction_impl
ClosedPublic

Authored by vitalybuka on Nov 8 2017, 4:36 PM.

Event Timeline

vitalybuka created this revision.Nov 8 2017, 4:36 PM
vitalybuka updated this revision to Diff 122181.Nov 8 2017, 4:57 PM

less moving

vitalybuka updated this revision to Diff 122182.Nov 8 2017, 5:02 PM

undo some changes

vitalybuka updated this revision to Diff 122184.Nov 8 2017, 5:05 PM

Undo more changes

eugenis added inline comments.Nov 9 2017, 1:27 PM
compiler-rt/lib/msan/msan_interceptors.cc
1009

why forward declarations? Just move the interceptors below the _impl definitions.

eugenis accepted this revision.Nov 9 2017, 1:28 PM

Ah ok I see your other change.

This revision is now accepted and ready to land.Nov 9 2017, 1:28 PM
vitalybuka marked an inline comment as done.Nov 9 2017, 2:51 PM
This revision was automatically updated to reflect the committed changes.