[clang] [python] [tests] Update TLSKind tests for newer MSVC versions

[mgorny]

Summary

The bump of default _MSC_VER which occurred in r315107 has caused
the '__declspec(thread)' TLSKind to change from STATIC to DYNAMIC.
Update the clang python binding tests accordingly. Test both for
behavior with old and new -fms-compatibility-version.

[frutiger]

Thanks for posting this on Phabricator, I had sent it to the mailing list last month.

[rnk]

lgtm

[mgorny]

@frutiger, do you maybe happen to have fixes for the two other test failures? Maybe I'm tracking them down unnecessarily ;-).

[frutiger]

I will commit this shortly.

@mgorny I have a fix for the unique_external issue here: https://reviews.llvm.org/D39161

[mgorny]

I see that you haven't more luck than I did finding a better solution. How about the code completion failure? I suppose I still have to figure that one out on my own ;-).

I can commit this one myself, I have it ready for commit already.

[frutiger]

Ah missed your last note. Committed as r317706.

bindings/python/tests/cindex/test_tls_kind.py

""", lang = 'cpp')
     assert tls_dynamic.tls_kind == TLSKind.DYNAMIC
 
     tls_static = get_cursor(tu.cursor, 'tls_static')
     assert tls_static.tls_kind == TLSKind.STATIC
 
     # The following case tests '__declspec(thread)'.  Since it is a Microsoft
     # specific extension, specific flags are required for the parser to pick
     # these up.
-    flags = ['-fms-extensions', '-target', 'x86_64-unknown-windows-win32']
+    flags = ['-fms-compatibility-version=18.00', '-fms-extensions',
+             '-target', 'x86_64-unknown-windows-win32']
     tu = get_tu("""
 __declspec(thread) int tls_declspec;
 """, lang = 'cpp', flags=flags)
 
     tls_declspec = get_cursor(tu.cursor, 'tls_declspec')
     assert tls_declspec.tls_kind == TLSKind.STATIC
 
+    flags = ['-fms-extensions', '-target', 'x86_64-unknown-windows-win32']
+    tu = get_tu("""
+__declspec(thread) int tls_declspec;
+""", lang = 'cpp', flags=flags)
+
+    tls_declspec = get_cursor(tu.cursor, 'tls_declspec')
+    assert tls_declspec.tls_kind == TLSKind.DYNAMIC