This is an archive of the discontinued LLVM Phabricator instance.

Differential D39780

Remove unused condition.
ClosedPublic

Authored by ruiu on Nov 7 2017, 8:20 PM.

Details

Reviewers
• rafael
Commits
rG1bf618a9dae2: Remove unused condition.
rL319395: Remove unused condition.
rLLD319395: Remove unused condition.
Summary

Looks like all tests pass without this isLocal().

Diff Detail

Event Timeline

ruiu created this revision.Nov 7 2017, 8:20 PM
Herald added subscribers: arichardson, emaste. · View Herald TranscriptNov 7 2017, 8:20 PM
ruiu added a comment.Nov 29 2017, 4:52 PM

Ping

Closed by commit rLLD319395: Remove unused condition. (authored by ruiu). · Explain WhyNov 29 2017, 5:08 PM
Closed by commit rL319395: Remove unused condition. (authored by ruiu). · Explain Why
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
ELF/
2 lines

Diff 122028

lld/ELF/Symbols.cpp

Show First 20 Lines • Show All 114 Lines • ▼ Show 20 Lines case Symbol::LazyObjectKind:
return 0; return 0;
} }
llvm_unreachable("invalid symbol kind"); llvm_unreachable("invalid symbol kind");
} }
// Returns true if this is a weak undefined symbol. // Returns true if this is a weak undefined symbol.
bool Symbol::isUndefWeak() const { bool Symbol::isUndefWeak() const {
// See comment on Lazy in Symbols.h for the details. // See comment on Lazy in Symbols.h for the details.
return !isLocal() && isWeak() && (isUndefined() || isLazy()); return isWeak() && (isUndefined() || isLazy());
} }
InputFile *Symbol::getFile() const { InputFile *Symbol::getFile() const {
if (isLocal()) { if (isLocal()) {
const SectionBase *Sec = cast<Defined>(this)->Section; const SectionBase *Sec = cast<Defined>(this)->Section;
// Local absolute symbols actually have a file, but that is not currently // Local absolute symbols actually have a file, but that is not currently
// used. We could support that by having a mostly redundant InputFile in // used. We could support that by having a mostly redundant InputFile in
// Symbol, or having a special absolute section if needed. // Symbol, or having a special absolute section if needed.
▲ Show 20 Lines • Show All 190 Lines • Show Last 20 Lines