Page MenuHomePhabricator

[clangd] Add ErrorCodes enum class.

Authored by hokein on Nov 7 2017, 1:23 AM.

Diff Detail


Event Timeline

hokein created this revision.Nov 7 2017, 1:23 AM
sammccall accepted this revision.Nov 7 2017, 1:47 AM
sammccall added inline comments.
35 ↗(On Diff #121847)

nit: could you call this ErrorCode? The plural doesn't make so much sense as a type name.

42 ↗(On Diff #121847)

serverErrorStart/End are not error codes, they're for comparing the numeric values to a range.

Given this is an enum class and we have to cast to int to do comparisons, I don't think these belong inside the enum, but rather as ints, outside it.

However, these limits aren't used at all yet, so probably just remove them for now.

This revision is now accepted and ready to land.Nov 7 2017, 1:47 AM
hokein updated this revision to Diff 121858.Nov 7 2017, 2:16 AM

Address review comments:

  • ErrorCodes => ErrorCode
  • Remove serverErrorStart/serverErrorEnd
hokein marked 2 inline comments as done.Nov 7 2017, 2:17 AM
This revision was automatically updated to reflect the committed changes.