This is an archive of the discontinued LLVM Phabricator instance.

[Polly] Fix using order, as this caused a test failure (NFC)
ClosedPublic

Authored by fhahn on Nov 6 2017, 6:09 AM.

Details

Summary

Without this patch, clang-format in check-polly fails for me, with current master:

FAILED: cd build/tools/polly && build/bin/clang-format -sort-includes -style=llvm llvm/tools/polly/include/polly/ScopPass.h | diff -u llvm/tools/polly/include/polly/ScopPass.h -
--- llvm/tools/polly/include/polly/ScopPass.h	2017-11-06 14:05:49.885345000 +0000
+++ -	2017-11-06 14:07:24.956241758 +0000
@@ -40,12 +40,12 @@
 } // namespace polly

 namespace llvm {
+using polly::SPMUpdater;
 using polly::Scop;
 using polly::ScopAnalysisManager;
 using polly::ScopAnalysisManagerFunctionProxy;
 using polly::ScopInfo;
 using polly::ScopStandardAnalysisResults;
-using polly::SPMUpdater;

 template <>
 class InnerAnalysisManagerProxy<ScopAnalysisManager, Function>::Result {

Diff Detail

Event Timeline

fhahn created this revision.Nov 6 2017, 6:09 AM
Meinersbur accepted this revision.Nov 6 2017, 6:23 AM

LGTM, fails for me too. Probably caused by change in clang-format: rL317325

This revision is now accepted and ready to land.Nov 6 2017, 6:23 AM
fhahn closed this revision.Nov 6 2017, 6:26 AM