This is an archive of the discontinued LLVM Phabricator instance.

[lit] Set shlibpath_var on Solaris
ClosedPublic

Authored by ro on Nov 5 2017, 7:00 AM.

Details

Summary

During make check-all on Solaris, lit complains

llvm-lit: /vol/gcc/src/llvm/llvm/dist/tools/clang/test/Unit/lit.cfg.py:57: warning: unable to inject shared library path on 'SunOS'

The following patch avoids this: Solaris uses LD_LIBRARY_PATH like several other targets.

In theory, once could also handle LD_LIBRARY_PATH_{32,64} which take precedence over
LD_LIBRARY_PATH if set, but let's cross that bridge when we get there.

Diff Detail

Event Timeline

ro created this revision.Nov 5 2017, 7:00 AM
lichray accepted this revision.Nov 5 2017, 8:09 AM
This revision is now accepted and ready to land.Nov 5 2017, 8:09 AM
ro added a comment.Nov 5 2017, 8:30 AM

Thanks. Could someone please commit it for me?

ro added a comment.Nov 13 2017, 3:31 AM

Could someone please commit this for me? I've no commit access.

Thanks.

ro added a comment.Nov 27 2017, 12:14 AM

It's been another two weeks, so: could someone please commit this for me? Thanks.

This revision was automatically updated to reflect the committed changes.