This is mostly a noop (most of the test diffs are renamed blocks).
There are a few temporary register renames (eax<->ecx) and a few blocks are
shuffled around.
See the discussion in PR33325 for more details.
Paths
| Differential D39456
[ExpandMemCmp] Split ExpandMemCmp from CodeGen into its own pass. ClosedPublic Authored by courbet on Oct 31 2017, 9:14 AM.
Details Summary This is mostly a noop (most of the test diffs are renamed blocks). See the discussion in PR33325 for more details.
Diff Detail
Event Timeline
Comment Actions LGTM. See inline for small changes before committing.
This revision is now accepted and ready to land.Nov 2 2017, 7:18 AM courbet marked 2 inline comments as done. Comment Actions
Comment Actions Thanks for the review !
Closed by commit rL317211: [ExpandMemCmp] Split ExpandMemCmp from CodeGen into its own pass. (authored by courbet). · Explain WhyNov 2 2017, 8:03 AM This revision was automatically updated to reflect the committed changes. courbet marked an inline comment as done.
Revision Contents
Diff 121311 llvm/trunk/include/llvm/InitializePasses.h
llvm/trunk/include/llvm/LinkAllPasses.h
llvm/trunk/include/llvm/Transforms/Scalar.h
llvm/trunk/lib/CodeGen/CodeGenPrepare.cpp
llvm/trunk/lib/CodeGen/TargetPassConfig.cpp
llvm/trunk/lib/Transforms/Scalar/CMakeLists.txt
llvm/trunk/lib/Transforms/Scalar/ExpandMemCmp.cpp
llvm/trunk/lib/Transforms/Scalar/Scalar.cpp
llvm/trunk/test/CodeGen/Generic/llc-start-stop.ll
llvm/trunk/test/CodeGen/X86/memcmp-optsize.ll
llvm/trunk/test/CodeGen/X86/memcmp.ll
llvm/trunk/test/Transforms/CodeGenPrepare/X86/memcmp.ll
llvm/trunk/test/Transforms/ExpandMemCmp/X86/lit.local.cfg
llvm/trunk/test/Transforms/ExpandMemCmp/X86/memcmp.ll
|