Page MenuHomePhabricator

[cmake] Remove policy conditionals
ClosedPublic

Authored by smeenai on Oct 30 2017, 6:56 PM.

Details

Summary

LLVM now requires a minimum of cmake 3.4.3, and all the policies
currently being set are present in that cmake version, so the
conditionals will always be true and are therefore unnecessary. The
movation is that the conditionals can give the false impression that the
policy settings are optional, whereas for example it's necessary to set
CMP0056 in order for check_linker_flags to operate correctly after
r316972. Inline the project version and language setting in the process.

Diff Detail

Repository
rL LLVM

Event Timeline

smeenai created this revision.Oct 30 2017, 6:56 PM
compnerd accepted this revision.Nov 2 2017, 1:31 PM
This revision is now accepted and ready to land.Nov 2 2017, 1:31 PM
This revision was automatically updated to reflect the committed changes.