[Reassociate] Remove FIXME from looptest.ll (NFC)

[fhahn]

Summary

The loop invariant add (i+j) is reassoicated, I think the FIXME can be removed, because this is what the test case tries to check (AFAIK). I also changed the test to use FileCheck.

[fhahn]

Chad, could you have a quick look, as it looks like you added the FIXME.

[davide]

LGTM

[davide]

When was this fixed, out of curiosity?

[fhahn]

I couldn't find a revision to pin down (I didn't try hard though).

But the previous check also checked for a similar thing, making sure reg115 and reg117 are not on the same line/used in the same instruction. So I am not entirely sure why the FIXME was still there.

[davide]

Please wait for Chad to comment, but this seems an OK change to me.

[mcrosier]

This probably comes from when I was adding support for FP in the reassociation pass many years ago. I don't recall exactly why I added the FIXME, but the original test was checking that (i+j) gets reassociated, so I agree with Florian's change.

test/Transforms/Reassociate/looptest.ll

 ; This testcase comes from this C fragment:
 ;
 ; void test(unsigned Num, int *Array) {
 ;  unsigned i, j, k;
 ;
 ;  for (i = 0; i != Num; ++i)
 ;    for (j = 0; j != Num; ++j)
 ;      for (k = 0; k != Num; ++k)
 ;        printf("%d\n", i+k+j);    /* Reassociate to (i+j)+k */
 ;}
 ;
 ; In this case, we want to reassociate the specified expr so that i+j can be
 ; hoisted out of the inner most loop.
 ;
-; RUN: opt < %s -reassociate -S | grep 115 | not grep 117
+; RUN: opt < %s -reassociate -S | FileCheck %s
 ; END.
 @.LC0 = internal global [4 x i8] c"%d\0A\00"    ; <[4 x i8]*> [#uses=1]
 
 declare i32 @printf(i8*, ...)
 
-; FIXME: No longer works.
+; Check that (i+j) has been reassociated (i=reg115, j=reg116)
+; CHECK: %reg113 = add i32 %reg116, %reg115
 define void @test(i32 %Num, i32* %Array) {
 bb0:
   %cond221 = icmp eq i32 0, %Num    ; <i1> [#uses=3]
   br i1 %cond221, label %bb7, label %bb2
 bb2:    ; preds = %bb6, %bb0
   %reg115 = phi i32 [ %reg120, %bb6 ], [ 0, %bb0 ]    ; <i32> [#uses=2]
   br i1 %cond221, label %bb6, label %bb3
 bb3:    ; preds = %bb5, %bb2