This is an archive of the discontinued LLVM Phabricator instance.

[dsymutil] Check AttrInfo.Name validity before using it
ClosedPublic

Authored by loladiro on Oct 26 2017, 9:54 AM.

Details

Summary

This upstreams a patch from the osxcross [1] toolchain.
It appears that llvm-dsymutil crashes at this place during GCC
bootstrap. Adding the check here seems reasonable, since it operates
on arbitrary input DWARF, not necessarily generated by the LLVM
toolchain, and it seems the un-mangled name need not necessarily exist.

Patch by Thomas Pöchtrager

[1] https://github.com/tpoechtrager/osxcross

Event Timeline

loladiro created this revision.Oct 26 2017, 9:54 AM
aprantl accepted this revision.Oct 26 2017, 10:18 AM
This revision is now accepted and ready to land.Oct 26 2017, 10:18 AM
This revision was automatically updated to reflect the committed changes.