[lldb] Fix warnings in the Windows build.

[zturner]

Summary

This fixes a number of trivial warnings in the Windows build. This is part of a larger effort to make the Windows build warning-free.

[zturner]

first time submitting a patch, trying to figure out how to get Phabricator to send the mail to lldb-commits.

[abidh]

Hi,
It looks OK to me. Built it on Linux and did not see any issue.

Regards,
Abid

[scottmg]

source/Target/Platform.cpp

534

"unsupported"

[zturner]

@abidh: Can you commit for me?

[zturner]

• Fix spelling error.

[domipheus]

confirmed lldb building fine on visual studio 13

[tfiala]

Hey guys,

I'll go ahead and submit this in a few after I do a test build / test run
over here.

[tfiala]

This built fine on Linux x86_64 (Ubuntu 12.04) and all tests passed (except for two that are intermittently failing in other scenarios - TestConnectionRemote and TestMultithreaded).

I'mm just waiting for the MacOSX build to finish up and then I'll mark as accepted and submit.

[tfiala]

MacOSX build fine too. LGTM.

[tfiala]

svn commit
Sending source/Commands/CommandObjectArgs.cpp
Sending source/Core/ConnectionFileDescriptor.cpp
Sending source/Host/common/SocketAddress.cpp
Sending source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp
Sending source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
Sending source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
Sending source/Target/Platform.cpp
Transmitting file data .......
Committed revision 209749.

source/Commands/CommandObjectArgs.cpp

 }
 
 Error
 CommandObjectArgs::CommandOptions::SetOptionValue (uint32_t option_idx, const char *option_arg)
 {
     Error error;
     
     const int short_option = m_getopt_table[option_idx].val;
-    
-    switch (short_option)
-    {
-        default:
-            error.SetErrorStringWithFormat("invalid short option character '%c'", short_option);
-            break;
-    }
     
     return error;
 }
 
 void
 CommandObjectArgs::CommandOptions::OptionParsingStarting ()
 {
 }

source/Core/ConnectionFileDescriptor.cpp

ConnectionFileDescriptor::Write (const void *src, size_t src_len, ConnectionStatus &status, Error *error_ptr)
 
 
     Error error;
 
     ssize_t bytes_sent = 0;
 
     switch (m_fd_send_type)
     {
-#ifndef LLDB_DISABLE_POSIX
         case eFDTypeFile:       // Other FD requireing read/write
+#ifndef LLDB_DISABLE_POSIX
             do
             {
                 bytes_sent = ::write (m_fd_send, src, src_len);
             } while (bytes_sent < 0 && errno == EINTR);
-            break;
 #endif
+            break;
         case eFDTypeSocket:     // Socket requiring send/recv
             do
             {
                 bytes_sent = ::send (m_fd_send, (char*)src, src_len, 0);
             } while (bytes_sent < 0 && errno == EINTR);
             break;
 
         case eFDTypeSocketUDP:  // Unconnected UDP socket requiring sendto/recvfrom

source/Host/common/SocketAddress.cpp

 GetFamilyLength (sa_family_t family)
 {
     switch (family)
     {
         case AF_INET:  return sizeof(struct sockaddr_in);
         case AF_INET6: return sizeof(struct sockaddr_in6);
     }
     assert(0 && "Unsupported address family");
+    return 0;
 }
 
 socklen_t
 SocketAddress::GetLength () const
 {
 #if defined(__APPLE__) || defined(__FreeBSD__) || defined(__NetBSD__)
     return m_socket_addr.sa.sa_len;
 #else

source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

if (memop == MemOp_LOAD && t == t2)
                 break;
                 
             default:
                 break;
         }
     }
     
     idx = LSL(llvm::SignExtend64<7>(imm7), scale);
-    size = 1 << scale;
+    size = (integer)1 << scale;
     uint64_t datasize = size * 8;
     uint64_t address;
     uint64_t wb_address;
     
     RegisterValue data_Rt;
     RegisterValue data_Rt2;
     
     //    if (vector)

source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp

 #include "Utility/StringExtractorGDBRemote.h"
 #include "ProcessGDBRemote.h"
 #include "ProcessGDBRemoteLog.h"
 #include "lldb/Host/Config.h"
 
 using namespace lldb;
 using namespace lldb_private;
 
-#ifdef LLDB_DISABLE_POSIX
+#if defined(LLDB_DISABLE_POSIX) && !defined(SIGSTOP)
 #define SIGSTOP 17
 #endif
 
 //----------------------------------------------------------------------
 // GDBRemoteCommunicationClient constructor
 //----------------------------------------------------------------------
 GDBRemoteCommunicationClient::GDBRemoteCommunicationClient(bool is_platform) :
     GDBRemoteCommunication("gdb-remote.client", "gdb-remote.client.rx_packet", is_platform),

source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

switch (dwarf_accessibility)
         case DW_ACCESS_public:      return eAccessPublic;
         case DW_ACCESS_private:     return eAccessPrivate;
         case DW_ACCESS_protected:   return eAccessProtected;
         default:                    break;
     }
     return eAccessNone;
 }
 
-#if defined(LLDB_CONFIGURATION_DEBUG) or defined(LLDB_CONFIGURATION_RELEASE)
+#if defined(LLDB_CONFIGURATION_DEBUG) || defined(LLDB_CONFIGURATION_RELEASE)
 
 class DIEStack
 {
 public:
     
     void Push (DWARFCompileUnit *cu, const DWARFDebugInfoEntry *die)
     {
         m_dies.push_back (DIEInfo(cu, die));

 TypeSP
 SymbolFileDWARF::ParseType (const SymbolContext& sc, DWARFCompileUnit* dwarf_cu, const DWARFDebugInfoEntry *die, bool *type_is_new_ptr)
 {
     TypeSP type_sp;
 
     if (type_is_new_ptr)
         *type_is_new_ptr = false;
 
-#if defined(LLDB_CONFIGURATION_DEBUG) or defined(LLDB_CONFIGURATION_RELEASE)
+#if defined(LLDB_CONFIGURATION_DEBUG) || defined(LLDB_CONFIGURATION_RELEASE)
     static DIEStack g_die_stack;
     DIEStack::ScopedPopper scoped_die_logger(g_die_stack);
 #endif
 
     AccessType accessibility = eAccessNone;
     if (die != NULL)
     {
         Log *log (LogChannelDWARF::GetLogIfAll(DWARF_LOG_DEBUG_INFO));
         if (log)
         {
             const DWARFDebugInfoEntry *context_die;
             clang::DeclContext *context = GetClangDeclContextContainingDIE (dwarf_cu, die, &context_die);
 
             GetObjectFile()->GetModule()->LogMessage (log, "SymbolFileDWARF::ParseType (die = 0x%8.8x, decl_ctx = %p (die 0x%8.8x)) %s name = '%s')",
                                                       die->GetOffset(),
                                                       static_cast<void*>(context),
                                                       context_die->GetOffset(),
                                                       DW_TAG_value_to_name(die->Tag()),
                                                       die->GetName(this, dwarf_cu));
 
-#if defined(LLDB_CONFIGURATION_DEBUG) or defined(LLDB_CONFIGURATION_RELEASE)
+#if defined(LLDB_CONFIGURATION_DEBUG) || defined(LLDB_CONFIGURATION_RELEASE)
             scoped_die_logger.Push (dwarf_cu, die);
             g_die_stack.LogDIEs(log, this);
 #endif
         }
 //
 //        Log *log (LogChannelDWARF::GetLogIfAll(DWARF_LOG_DEBUG_INFO));
 //        if (log && dwarf_cu)
 //        {

source/Target/Platform.cpp

switch (file_type)
             break;
             
         case FileSpec::eFileTypeInvalid:
         case FileSpec::eFileTypeOther:
         case FileSpec::eFileTypeUnknown:
             rc_baton->error.SetErrorStringWithFormat("invalid file detected during copy: %s", src.GetPath().c_str());
             return FileSpec::eEnumerateDirectoryResultQuit; // got an error, bail out
             break;
+        default:
+            return FileSpec::eEnumerateDirectoryResultQuit; // usnupported file type, bail out
+            break;
     }
 }
 
 Error
 Platform::Install (const FileSpec& src, const FileSpec& dst)
 {
     Error error;