Page MenuHomePhabricator

[clang-format] Sort whole block of using declarations while partially formatting
ClosedPublic

Authored by krasimir on Oct 17 2017, 5:09 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

krasimir created this revision.Oct 17 2017, 5:09 PM
djasper added inline comments.Oct 18 2017, 11:31 AM
lib/Format/UsingDeclarationsSorter.cpp
79 ↗(On Diff #119405)

I'd prefer to iterator over UsingDeclarations here and see whether any of the contained lines is Affected. Seems like a much more encapsulated way to do this and prevents you from needing the awkward in-out parameter.

krasimir updated this revision to Diff 119518.Oct 18 2017, 12:55 PM
  • Address review comments
krasimir marked an inline comment as done.Oct 18 2017, 12:56 PM
This revision is now accepted and ready to land.Oct 18 2017, 2:19 PM
This revision was automatically updated to reflect the committed changes.