Page MenuHomePhabricator

[CMake] Build Fuchsia toolchain as -O3
ClosedPublic

Authored by phosek on Oct 17 2017, 12:39 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Oct 17 2017, 12:39 PM
mcgrathr accepted this revision.Oct 17 2017, 12:41 PM

LGTM
Since we use lld, -Wl,-O2 also helps make the binaries smaller.

This revision is now accepted and ready to land.Oct 17 2017, 12:41 PM
ruiu added a subscriber: ruiu.Oct 17 2017, 2:59 PM

Yes, specifically, lld does string tail merging (instead of regular string merging) when -O2 is given, so it would produce slightly smaller outputs.

It seems like with the current patch, CMake already sets -Wl,-O3 so that should be sufficient.

This revision was automatically updated to reflect the committed changes.