This is an archive of the discontinued LLVM Phabricator instance.

Added SpecialCastList fuzzer.
ClosedPublic

Authored by hctim on Oct 16 2017, 3:53 PM.

Details

Reviewers
morehouse

Event Timeline

hctim created this revision.Oct 16 2017, 3:53 PM
hctim edited the summary of this revision. (Show Details)Oct 16 2017, 3:55 PM
morehouse added inline comments.Oct 16 2017, 5:11 PM
tools/llvm-special-case-list-fuzzer/special-case-list-fuzzer.cpp
17

It is discouraged to store StringRefs unnecessarily. See http://llvm.org/doxygen/classllvm_1_1StringRef.html#details.

In this case, you can probably just create the StringRef as an rvalue to the call below.

Also prefer static_cast over C-style cast.

22

Fuzz targets should not exit. See https://llvm.org/docs/LibFuzzer.html#fuzz-target. Return instead.

hctim marked 2 inline comments as done.Oct 16 2017, 6:24 PM
hctim updated this revision to Diff 119238.Oct 16 2017, 6:25 PM
  • morehouse@ comments.
This revision is now accepted and ready to land.Oct 17 2017, 8:56 AM
morehouse closed this revision.Oct 17 2017, 10:46 AM

Landed as r316014.