This is an archive of the discontinued LLVM Phabricator instance.

COFF: Don't add /manifest* flags to the response file.
ClosedPublic

Authored by pcc on Oct 16 2017, 2:06 PM.

Details

Summary

If /manifest:embed is enabled we're already creating a resource file
out of these flags and adding it to the linkrepro, and it doesn't
seem worth being able to repro side-by-side manifests.

No tests because this requires Windows and the linkrepro tests
require not-Windows.

Event Timeline

pcc created this revision.Oct 16 2017, 2:06 PM
ruiu accepted this revision.Oct 24 2017, 9:37 PM

LGTM

This revision is now accepted and ready to land.Oct 24 2017, 9:37 PM
This revision was automatically updated to reflect the committed changes.